openSUSE Test suite #5027

yubiuser · 2022-11-18T21:25:30Z

Dummy PR to trigger the test suite for #5001

yubiuser · 2022-11-18T22:57:43Z

To pass the tests this needs

adjustment of dev-supportedos.pi-hole.net
Merge of Don't install which #5028
Rebase of the adjustments of the changes to the installer in basic-install with openSUSE support #5001

Signed-off-by: Christian König <[email protected]>

rdwebdesign · 2022-11-22T17:59:50Z

Dockerfile

@@ -0,0 +1,26 @@
+FROM opensuse/leap:15.4
+RUN zypper install -y --no-recommends git dbus-1 systemd-sysvinit


Maybe we need to add # hadolint ignore=DL3037 here, but I think the zypper clean should be used.

clean is a good idea, but I don' think we should pin the versions installed.
If a newer version breaks anything I'd like to know.

I don' think we should pin the versions installed

I don't think this too. That's why I suggested to include # hadolint ignore=DL3037, to silence this check.

Apparently the command didn't work.

Signed-off-by: Christian König <[email protected]>

rdwebdesign · 2022-11-22T21:17:10Z

automated install/basic-install.sh

+          PKG_COUNT="${PKG_MANAGER} lu | egrep '(.i686|.x86|.noarch|.arm|.src)' | wc -l || true"
+          INSTALLER_DEPS=(git dialog iproute2 newt procps which ca-certificates)
+          PIHOLE_DEPS=(cronie curl findutils sudo unzip libidn2 psmisc libcap-ng0 netcat-openbsd jq)
+          PIHOLE_WEB_DEPS=(lighttpd php8 php8-fastcgi php8-cli php8-pdo php8-intl php8-openssl php8-sqlite)


Are you sure there are PHP8 packages to openSUSE Leap?

The following 25 NEW packages are going to be installed:\n cron cronie jq libbrotlienc1 libbsd0 libdbi3 libicu-suse65_1 libicu65_1-ledata libjq1 libonig4 lighttpd mailx netcat-openbsd php8 php8-cli php8-fastcgi php8-intl php8-openssl php8-pdo php8-sqlite

This part was just copied from #5001

https://software.opensuse.org/package/php8?locale=en

php8

Interpreter for the PHP scripting language version 8

PHP is a server-side HTML embedded scripting language designed primarily for web development but also used as a general-purpose programming language. This package contains the base files for all subpackages and must be installed in order to use PHP. Additionally, extension modules and server modules (e.g. for Apache) may be installed.

There is no official package available for openSUSE Leap 15.4

Interesting, my local container says otherwise

1c9a8e950408:/ # php -v PHP 8.0.25 (cli) (built: Oct 31 2022 12:00:00) ( NTS ) Copyright (c) The PHP Group Zend Engine v4.0.25, Copyright (c) Zend Technologies

What image are you using? What architecture?
Maybe there is a package difference between different architectures.

FROM opensuse/leap:15.4

It's a x86_64 system

I'm testing on a Raspberry Pi. Maybe the difference is there.

I'm not sure if there will be someone running openSUSE on a Raspberry Pi.

Signed-off-by: Christian König <[email protected]>

yubiuser · 2022-11-25T21:29:42Z

Added code from #4924 and adjusted tests.

Signed-off-by: Christian König <[email protected]>

bcambl · 2022-12-13T01:55:37Z

automated install/basic-install.sh

        # Then check if dnf or yum is the package manager
        if is_command dnf ; then
            PKG_MANAGER="dnf"
-        else


replacing this else with an elif might potentially leave PKG_MANAGER unset.

I think the best code should be:

if is_command dnf ; then PKG_MANAGER="dnf" elif is_command zypper ; then PKG_MANAGER="zypper" else PKG_MANAGER="yum" fi

Or, if you don't want to use else:

PKG_MANAGER="yum" if is_command dnf ; then PKG_MANAGER="dnf" elif is_command zypper ; then PKG_MANAGER="zypper" fi

Good catch.

Makes sense.

github-actions · 2022-12-19T20:09:44Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

yubiuser · 2022-12-22T12:21:58Z

Superseded by #5083. It was easier to make a new one then to clean up this big PR.

yubiuser force-pushed the openSUSE branch from 2dc1edf to 212e8cb Compare November 18, 2022 22:46

yubiuser mentioned this pull request Nov 18, 2022

Don't install which #5028

Merged

1 task

yubiuser added 3 commits November 19, 2022 07:04

Add openSUSE Thumbleweed to test suite

ffcc0f9

Signed-off-by: Christian König <[email protected]>

Install git

cc7b625

Signed-off-by: Christian König <[email protected]>

Adjust basic-install.sh

0dd8ce2

Signed-off-by: Christian König <[email protected]>

yubiuser force-pushed the openSUSE branch from 212e8cb to 0dd8ce2 Compare November 19, 2022 06:07

Use openSUSE leap 15.4

e47f418

Signed-off-by: Christian König <[email protected]>

yubiuser force-pushed the openSUSE branch from ee83227 to e47f418 Compare November 20, 2022 09:25

yubiuser added 3 commits November 20, 2022 10:47

Update basic-install.sh to latest code

167b6bc

Signed-off-by: Christian König <[email protected]>

Fix creating pihole group.

07f3470

Signed-off-by: Christian König <[email protected]>

Add nectcat

32db837

Signed-off-by: Christian König <[email protected]>

PromoFaux changed the title ~~openSUSE Test suit~~ openSUSE Test suite Nov 20, 2022

Add systemd

88cbc8c

Signed-off-by: Christian König <[email protected]>

yubiuser force-pushed the openSUSE branch from ac8c44a to 88cbc8c Compare November 20, 2022 21:51

yubiuser added 8 commits November 21, 2022 21:06

Update basic-install to latest version

7cd77fb

Signed-off-by: Christian König <[email protected]>

Revert Add native systemd unit

4fff72d

Signed-off-by: Christian König <[email protected]>

Update

7d642e7

Signed-off-by: Christian König <[email protected]>

Mkdir

03cbc51

Signed-off-by: Christian König <[email protected]>

Test

b1485b1

Signed-off-by: Christian König <[email protected]>

DoN't mock systemctl

64d5f89

Signed-off-by: Christian König <[email protected]>

Fix systemctl

7422029

Signed-off-by: Christian König <[email protected]>

Fix now.

bf9cfc4

Signed-off-by: Christian König <[email protected]>

rdwebdesign requested changes Nov 22, 2022

View reviewed changes

yubiuser added 2 commits November 22, 2022 19:54

Fix CodeFactor

a352199

Signed-off-by: Christian König <[email protected]>

Dockerfile removed

75c90a1

Signed-off-by: Christian König <[email protected]>

yubiuser force-pushed the openSUSE branch from b908132 to 75c90a1 Compare November 22, 2022 19:28

yubiuser added 2 commits November 22, 2022 21:20

Add hack

8c5b95d

Signed-off-by: Christian König <[email protected]>

Do not hack

8f1ff84

Signed-off-by: Christian König <[email protected]>

rdwebdesign reviewed Nov 22, 2022

View reviewed changes

Check for man pages as well

5bb4daf

Signed-off-by: Christian König <[email protected]>

This was referenced Nov 24, 2022

Do not require man pages to be present in test script #5037

Merged

Always set lighttpd config dir permissions #5038

Merged

Explicitly create group pihole on installation #5039

Merged

yubiuser added 7 commits November 24, 2022 22:23

DoN#t hard-code php

98607b3

Signed-off-by: Christian König <[email protected]>

No which

3baf88f

Signed-off-by: Christian König <[email protected]>

Add tumblewed and new group code

47bbc6a

Signed-off-by: Christian König <[email protected]>

Add native systemd service file

1bd38e5

Signed-off-by: Christian König <[email protected]>

Rename

c2a0e1f

Signed-off-by: Christian König <[email protected]>

Adjust test for native systemd unit file

83f983f

Signed-off-by: Christian König <[email protected]>

Tweak

4424166

Signed-off-by: Christian König <[email protected]>

yubiuser force-pushed the openSUSE branch from fc78d35 to 4424166 Compare November 25, 2022 21:26

Allow rolling release OS version to be set to any

9b7e053

Signed-off-by: Christian König <[email protected]>

bcambl reviewed Dec 13, 2022

View reviewed changes

yubiuser mentioned this pull request Dec 13, 2022

basic-install with openSUSE support #5001

Closed

1 task

github-actions bot added the PR: Merge Conflict Issue blocking check and merge of code label Dec 19, 2022

yubiuser mentioned this pull request Dec 22, 2022

Make install script compatible with openSUSE #5083

Closed

1 task

yubiuser closed this Dec 22, 2022

yubiuser deleted the openSUSE branch December 22, 2022 12:23

		@@ -0,0 +1,26 @@
		FROM opensuse/leap:15.4
		RUN zypper install -y --no-recommends git dbus-1 systemd-sysvinit

Uh oh!

openSUSE Test suite #5027

openSUSE Test suite #5027

Uh oh!

Conversation

yubiuser commented Nov 18, 2022

Uh oh!

yubiuser commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yubiuser commented Nov 25, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rdwebdesign Dec 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 19, 2022

Uh oh!

yubiuser commented Dec 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yubiuser commented Nov 18, 2022 •

edited

Loading

rdwebdesign Dec 13, 2022 •

edited

Loading