[[BF103]](#103) Moved SignUpTest to commonMain

CHANGELOG.md

@@ -1,5 +1,9 @@
 # 0.0.29
 
+## PiMonitor Client SDK Core
+
+- [[BF103]](https://github.com/picortex/bitframe/issues/103) Moved SignUpTest to commonMain
+
 ## Bitframe Authentication Service
 
 ### Bug Fixes

bitframe-client/sdks/test/src/commonMain/kotlin/bitframe/authentication/TestClientConfiguration.kt

@@ -36,6 +36,9 @@ class TestClientConfiguration @JvmOverloads private constructor(
             simulationTime: Int = DEFAULT_SIMULATION_TIME,
             scope: CoroutineScope = CoroutineScope(SupervisorJob() + Dispatchers.Default)
         ) = invoke(appId, simulationTime, scope)
+
+        @JvmStatic
+        fun from(config: ServiceConfig, appId: String) = invoke(appId, scope = config.scope)
     }
 
     fun toDaoConfig() = TestDaoConfig(simulationTime, scope)

pi-monitor/pi-monitor-client/sdks/core/build.gradle.kts

@@ -12,7 +12,7 @@ kotlin {
     js(IR) {
         val main by compilations
         main.outputModuleName = "pi-monitor-client-sdk-core"
-        browserLib()
+        library()
         binaries.library()
     }
 
@@ -32,15 +32,11 @@ kotlin {
 
         val commonTest by getting {
             dependencies {
+                implementation(project(":pi-monitor-test-testing"))
                 implementation(asoft("expect-coroutines", vers.asoft.expect))
             }
         }
 
-        val jvmMain by getting {
-            dependencies {
-                implementation(project(":pi-monitor-test-testing"))
-            }
-        }
         val jsMain by getting {
             dependencies {
                 api(kotlinx("coroutines-core", vers.kotlinx.coroutines))

pi-monitor/pi-monitor-client/sdks/core/src/jvmTest/kotlin/acceptance/authentication/IndividualRegistrationParamsUtils.kt → pi-monitor/pi-monitor-client/sdks/core/src/commonTest/kotlin/core/authentication/IndividualRegistrationParamsUtils.kt

@@ -1,9 +1,9 @@
-package acceptance.authentication
+package core.authentication
 
 import bitframe.authentication.signin.SignInCredentials
 import pimonitor.authentication.signup.IndividualRegistrationParams
 
 internal fun IndividualRegistrationParams.credentials() = SignInCredentials(
-    alias = email.toString(),
-    password = password.toString()
+    alias = email,
+    password = password
 )

pi-monitor/pi-monitor-client/sdks/core/src/jvmTest/kotlin/acceptance/authentication/SignUpServiceKtorServiceTest.kt → pi-monitor/pi-monitor-client/sdks/core/src/commonTest/kotlin/core/authentication/SignUpServiceTest.kt

@@ -1,22 +1,22 @@
-package acceptance.authentication
+package core.authentication
 
-import acceptance.utils.IntegrationTest
 import expect.expect
 import kotlinx.coroutines.runTest
 import kotlinx.datetime.Clock
 import later.await
-import org.junit.jupiter.api.TestInstance
-import org.testcontainers.junit.jupiter.Testcontainers
-import pimonitor.authentication.signup.IndividualRegistrationParams
 import pimonitor.PiMonitorService
-import pimonitor.ktor.PiMonitorServiceKtor
+import pimonitor.authentication.signup.IndividualRegistrationParams
+import testing.IntegrationTest
+import testing.annotations.Lifecycle
+import testing.annotations.TestInstance
+import testing.annotations.Testcontainers
 import kotlin.test.Test
 
 @Testcontainers
-@TestInstance(TestInstance.Lifecycle.PER_CLASS)
-class SignUpServiceKtorServiceTest : IntegrationTest() {
+@TestInstance(Lifecycle.PER_CLASS)
+abstract class SignUpServiceTest : IntegrationTest() {
 
-    private val service: PiMonitorService by lazy { PiMonitorServiceKtor(config) }
+    abstract val service: PiMonitorService
 
     @Test
     fun should_register_an_individual() = runTest {

pi-monitor/pi-monitor-client/sdks/core/src/commonTest/kotlin/integration/authentication/SignUpServiceIntegrationTest.kt

@@ -0,0 +1,30 @@
+package integration.authentication
+
+import bitframe.authentication.TestClientConfiguration
+import bitframe.service.config.KtorClientConfiguration
+import core.authentication.SignUpServiceTest
+import expect.expect
+import pimonitor.PiMonitorService
+import pimonitor.ktor.PiMonitorServiceKtor
+import pimonitor.test.PiMonitorServiceTest
+import testing.annotations.Lifecycle
+import testing.annotations.TestInstance
+import testing.annotations.Testcontainers
+import kotlin.test.Test
+
+@Testcontainers
+@TestInstance(Lifecycle.PER_CLASS)
+class SignUpServiceIntegrationTest : SignUpServiceTest() {
+
+    override val service: PiMonitorService by lazy {
+        when (val cfg = config) {
+            is KtorClientConfiguration -> PiMonitorServiceKtor(cfg)
+            else -> PiMonitorServiceTest(TestClientConfiguration.from(cfg, "test-app"))
+        }
+    }
+
+    @Test
+    fun should_pass() {
+        expect(1 + 1).toBe(2)
+    }
+}

pi-monitor/pi-monitor-client/sdks/core/src/commonTest/kotlin/unit/authentication/SignUpServiceUnitTest.kt

@@ -0,0 +1,27 @@
+package unit.authentication
+
+import bitframe.authentication.TestClientConfiguration
+import bitframe.service.config.KtorClientConfiguration
+import core.authentication.SignUpServiceTest
+import expect.expect
+import pimonitor.PiMonitorService
+import pimonitor.ktor.PiMonitorServiceKtor
+import pimonitor.test.PiMonitorServiceTest
+import testing.annotations.Lifecycle
+import testing.annotations.TestInstance
+import testing.annotations.Testcontainers
+import kotlin.test.Test
+
+@Testcontainers
+@TestInstance(Lifecycle.PER_CLASS)
+class SignUpServiceUnitTest : SignUpServiceTest() {
+
+    override val service: PiMonitorService by lazy {
+        PiMonitorServiceTest(TestClientConfiguration.from(config, "test-app"))
+    }
+
+    @Test
+    fun should_pass() {
+        expect(1 + 1).toBe(2)
+    }
+}