-
Notifications
You must be signed in to change notification settings - Fork 144
Add support for 7.3" and 13.3" Spectra 6 displays #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| class Inky: | ||
| """Inky e-Ink Display Driver.""" | ||
|
|
||
| BLACK = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these need to match the weird gappy colours? For users calling set_pixel rather than setting a PIL image.
ie:
BLACK = 0
WHITE = 1
YELLOW = 2
RED = 3
BLUE = 5
GREEN = 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Gadgetoid, sorry to barge into the PR like this. I am just wondering what you mean by "gappy colours"?
I am looking to port this driver to .NET and am trying to follow along.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colour "4" doesn't map to a specific colour on the display. I believe it comes out white, but there's no guarantee. It's mostly a concern with our implementation due to the way we handle dithering but the constants need to also reflect that there's no 4. Gappy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect - thanks for the explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colour "4" doesn't map to a specific colour on the display. I believe it comes out white, but there's no guarantee. It's mostly a concern with our implementation due to the way we handle dithering but the constants need to also reflect that there's no 4. Gappy!
It's orange on my 7.3" from waveshare, but apparently not on the 13.3".
waveshareteam/e-Paper#377
|
Thank you! |
No description provided.