Skip to content

Conversation

@thirdr
Copy link
Contributor

@thirdr thirdr commented Apr 17, 2025

No description provided.

class Inky:
"""Inky e-Ink Display Driver."""

BLACK = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to match the weird gappy colours? For users calling set_pixel rather than setting a PIL image.

ie:

BLACK = 0
WHITE = 1
YELLOW = 2
RED = 3
BLUE = 5
GREEN = 6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gadgetoid, sorry to barge into the PR like this. I am just wondering what you mean by "gappy colours"?

I am looking to port this driver to .NET and am trying to follow along.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour "4" doesn't map to a specific colour on the display. I believe it comes out white, but there's no guarantee. It's mostly a concern with our implementation due to the way we handle dithering but the constants need to also reflect that there's no 4. Gappy!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect - thanks for the explanation!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colour "4" doesn't map to a specific colour on the display. I believe it comes out white, but there's no guarantee. It's mostly a concern with our implementation due to the way we handle dithering but the constants need to also reflect that there's no 4. Gappy!

It's orange on my 7.3" from waveshare, but apparently not on the 13.3".
waveshareteam/e-Paper#377

@Gadgetoid Gadgetoid merged commit b3d50ff into main Apr 24, 2025
10 of 11 checks passed
@Gadgetoid
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants