-
Notifications
You must be signed in to change notification settings - Fork 105
[ce] repository control plane and data plane #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsert working? temp routing name fetch list type name inline request body for upsert upsert request body _id magic . Simple HTTP impl update route name updates
5802a93
to
fef0ce6
Compare
ssmith-pc
commented
Sep 19, 2025
rohanshah18
reviewed
Sep 22, 2025
rohanshah18
reviewed
Sep 22, 2025
rohanshah18
reviewed
Sep 22, 2025
rohanshah18
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have some concerns around:
- Using custom vs openApi generated client
- Lack of testing
looks good from a standpoint of type correctness, can't comment on SDK specific mechanics. dunder methods make sense intuitively |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
First pass implementation of control plane SDK for repositories.
Also includes a basic data plane impl that avoids using the OpenAPI generated types due to Document being such an open-ended type. More work is needed here
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Type of Change
Test Plan
Describe specific steps for validating this change.