Return inherited type #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinnymz
requested changes
Mar 6, 2023
Owner
pinnymz
left a comment
pinnymz
left a comment
There was a problem hiding this comment.
Thanks for finding/fixing this! One minor comment on the test approach, would be happy to merge if you can resolve that.
test/test_jewish_calendar.py
Outdated
| self.assertEqual(calendar.sof_zman_kiddush_levana_between_moldos().toordinal(), expected_time.toordinal()) | ||
|
|
||
| def test_date_arithmetic_returns_inherited_type(self): | ||
| for instance, type in [(JewishCalendar(5783, 1, 1), JewishCalendar), (JewishDate(5783, 1, 1), JewishDate)]: |
Owner
There was a problem hiding this comment.
I'd prefer to keep other types out of this batch of tests, JewishCalendar alone should suffice here. An alternative approach would be to test the method in TestJewishDate, and create a dummy class to ensure the type isn't being lost.
Contributor
Author
There was a problem hiding this comment.
Duly noted, indeed keeps the code-base clean.
pinnymz
reviewed
Mar 6, 2023
pinnymz
approved these changes
Mar 10, 2023
Owner
|
Replaced by PR#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an instance of the sub-classed
JewishDatetype when applying any of the baseJewishDatemethods (__add__and__sub__).