Skip to content

[Bug Fix] Handle Incalculable Zmanim, Correct Typing, Add Github Action Tests #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[Bug Fix] Handle Incalculable Zmanim, Correct Typing, Add Github Action Tests #16

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b89ec6f
Handle Incalculable Zmanim
dickermoshe Jul 9, 2023
47854f1
Make `AstronomicalCalculations` an abstract class
dickermoshe Jul 9, 2023
5b29dc1
Fixes in Jewish Date
dickermoshe Jul 9, 2023
5fc3e38
Tests for Incalculable Zmanim
dickermoshe Jul 9, 2023
c6711f6
Create test.yml
dickermoshe Jul 9, 2023
a7eebfe
Update test.yml
dickermoshe Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make AstronomicalCalculations an abstract class
  • Loading branch information
@dickermoshe
dickermoshe committed Jul 9, 2023
commit 47854f1cd89a51f9b9686fdb4d2184ade8368dab
18 changes: 16 additions & 2 deletions zmanim/util/astronomical_calculations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import math
from datetime import date
from typing import Optional
from abc import ABC, abstractmethod

from zmanim.util.geo_location import GeoLocation

class AstronomicalCalculations:


class AstronomicalCalculations(ABC):
GEOMETRIC_ZENITH = 90.0

def __init__(self):
Expand All @@ -15,4 +21,12 @@ def elevation_adjustment(self, elevation: float) -> float:
def adjusted_zenith(self, zenith: float, elevation: float) -> float:
if zenith != self.GEOMETRIC_ZENITH:
return zenith
return zenith + self.solar_radius + self.refraction + self.elevation_adjustment(elevation)
return zenith + self.solar_radius + self.refraction + self.elevation_adjustment(elevation)

@abstractmethod
def utc_sunrise(self, target_date: date, geo_location: GeoLocation, zenith: float, adjust_for_elevation: bool = False) -> Optional[float]:
pass

@abstractmethod
def utc_sunset(self, target_date: date, geo_location: GeoLocation, zenith: float, adjust_for_elevation: bool = False) -> Optional[float]:
pass