Skip to content

Conversation

@10xLaCroixDrinker
Copy link
Contributor

@10xLaCroixDrinker 10xLaCroixDrinker commented Mar 22, 2024

PR 3 of 3 for pinojs/pino#1925

Relates to pinojs/thread-stream#145
Relates to pinojs/pino#1930

This still requires some changes to types. New overloads need to be added since it conditionally returns a Promise.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8396963026

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8362242888: 0.0%
Covered Lines: 67
Relevant Lines: 67

💛 - Coveralls

Co-authored-by: James Sumners <[email protected]>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0ba2e9f into pinojs:main Apr 22, 2024
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/load-config-from-pino branch April 22, 2024 19:25
renovate bot referenced this pull request in redwoodjs/graphql May 16, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[pino-abstract-transport](https://github.com/pinojs/pino-abstract-transport)
| [`1.1.0` ->
`1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-abstract-transport
(pino-abstract-transport)</summary>

###
[`v1.2.0`](https://github.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0)

[Compare
Source](https://github.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0)

#### What's Changed

- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/80](https://github.com/pinojs/pino-abstract-transport/pull/80)
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/82](https://github.com/pinojs/pino-abstract-transport/pull/82)
- build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/83](https://github.com/pinojs/pino-abstract-transport/pull/83)
- build(deps-dev): bump husky from 8.0.3 to 9.0.6 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/84](https://github.com/pinojs/pino-abstract-transport/pull/84)
- build(deps): bump actions/cache from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/85](https://github.com/pinojs/pino-abstract-transport/pull/85)
- docs(readme): fix broken badge URLs by
[@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-abstract-transport/pull/88](https://github.com/pinojs/pino-abstract-transport/pull/88)
- refactor: remove objectMode argument as it is ignored by Duplex.from
by [@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker)
in
[https://github.com/pinojs/pino-abstract-transport/pull/89](https://github.com/pinojs/pino-abstract-transport/pull/89)
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/91](https://github.com/pinojs/pino-abstract-transport/pull/91)
- feat: load config from pino on startup by
[@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-abstract-transport/pull/90](https://github.com/pinojs/pino-abstract-transport/pull/90)
- Make the tests compatible with Node 18 and 20 by
[@&#8203;donwellus](https://github.com/donwellus) in
[https://github.com/pinojs/pino-abstract-transport/pull/94](https://github.com/pinojs/pino-abstract-transport/pull/94)

#### New Contributors

- [@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker)
made their first contribution in
[https://github.com/pinojs/pino-abstract-transport/pull/88](https://github.com/pinojs/pino-abstract-transport/pull/88)
- [@&#8203;donwellus](https://github.com/donwellus) made their first
contribution in
[https://github.com/pinojs/pino-abstract-transport/pull/94](https://github.com/pinojs/pino-abstract-transport/pull/94)

**Full Changelog**:
pinojs/pino-abstract-transport@v1.1.0...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM referenced this pull request in redwoodjs/graphql May 17, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[pino-abstract-transport](https://github.com/pinojs/pino-abstract-transport)
| [`1.1.0` ->
`1.2.0`](https://renovatebot.com/diffs/npm/pino-abstract-transport/1.1.0/1.2.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-abstract-transport/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-abstract-transport/1.1.0/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-abstract-transport
(pino-abstract-transport)</summary>

###
[`v1.2.0`](https://github.com/pinojs/pino-abstract-transport/releases/tag/v1.2.0)

[Compare
Source](https://github.com/pinojs/pino-abstract-transport/compare/v1.1.0...v1.2.0)

#### What's Changed

- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/80](https://github.com/pinojs/pino-abstract-transport/pull/80)
- build(deps): bump actions/setup-node from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/82](https://github.com/pinojs/pino-abstract-transport/pull/82)
- build(deps-dev): bump tsd from 0.28.1 to 0.30.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/83](https://github.com/pinojs/pino-abstract-transport/pull/83)
- build(deps-dev): bump husky from 8.0.3 to 9.0.6 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/84](https://github.com/pinojs/pino-abstract-transport/pull/84)
- build(deps): bump actions/cache from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/85](https://github.com/pinojs/pino-abstract-transport/pull/85)
- docs(readme): fix broken badge URLs by
[@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-abstract-transport/pull/88](https://github.com/pinojs/pino-abstract-transport/pull/88)
- refactor: remove objectMode argument as it is ignored by Duplex.from
by [@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker)
in
[https://github.com/pinojs/pino-abstract-transport/pull/89](https://github.com/pinojs/pino-abstract-transport/pull/89)
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-abstract-transport/pull/91](https://github.com/pinojs/pino-abstract-transport/pull/91)
- feat: load config from pino on startup by
[@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-abstract-transport/pull/90](https://github.com/pinojs/pino-abstract-transport/pull/90)
- Make the tests compatible with Node 18 and 20 by
[@&#8203;donwellus](https://github.com/donwellus) in
[https://github.com/pinojs/pino-abstract-transport/pull/94](https://github.com/pinojs/pino-abstract-transport/pull/94)

#### New Contributors

- [@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker)
made their first contribution in
[https://github.com/pinojs/pino-abstract-transport/pull/88](https://github.com/pinojs/pino-abstract-transport/pull/88)
- [@&#8203;donwellus](https://github.com/donwellus) made their first
contribution in
[https://github.com/pinojs/pino-abstract-transport/pull/94](https://github.com/pinojs/pino-abstract-transport/pull/94)

**Full Changelog**:
pinojs/pino-abstract-transport@v1.1.0...v1.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants