browser: logger does not pass arguments to write function

[Morriz]

when logging this way:

const log = logger('context')

log.debug('bla', { di: 'da' })

the arguments do not end up anywhere in the write function:

...
     browser: {
      write: (logObj, ...logParams) => {
        const { level, msg, time } = logObj as Record<string, string>
        const timeFormatted = new Date(time).toISOString()
        const levelColor = levelColors[level as keyof typeof levelColors]
        console.log(`[${timeFormatted}] ${levelColor}${level} ${color.cyan} ${msg} ${color.white}`, ...logParams)
      },
      formatters: {
        level: label => {
          return {
            level: label,
          }
        },
      },
    },
...

arguments always has length 1. Neither logObj contains them, and logParams is always undefined.

[Morriz]

ok, it seems this can be done with asObjectBindingsOnly but that hasn't been published correctly yet: #2234

[Morriz]

Nope, I tried it and it still passes a stringified version of the arguments passed to the log functions. So something is touching the input and doing that:

...
    browser: {
      // @ts-ignore
      asObjectBindingsOnly: true,
      write: (logObj, ...logParams) => {
        const { level, time } = logObj as Record<string, string>
        const timeFormatted = new Date(time).toISOString()
        const levelColor = levelColors[level as keyof typeof levelColors]
        console.log(`[${timeFormatted}] ${levelColor}${level}${color.cyan} ${mod} > ${color.white}`, logParams)
        if (process.env.NODE_ENV === 'development') {
          bufferClientLog({ ...logObj, args: logParams })
        }
      },
      formatters: {
        level: label => {
          return {
            level: label,
          }
        },
      },
    },
...

logParams is always just an array of length 1 with the stringified args passed to the log fn:

['"bla" {"di":"da"}']