Skip to content

fix: make transports.options and transports.level optional #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 2 commits into from
Nov 15, 2023
Merged

fix: make transports.options and transports.level optional #1831

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b92542
fix: make transports.options and transports.level optional
krosenk729 Oct 17, 2023
5010260
adding test for optional level/options
krosenk729 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: make transports.options and transports.level optional 
According to https://github.com/pinojs/pino/blob/HEAD/docs/transports.md#v7-transports, the options and level are non-required properties for a transport
  • Loading branch information
@krosenk729
krosenk729 authored Oct 17, 2023
commit 0b9254235510c7833bd1f2ec6000ca9f6e718b1c
4 changes: 2 additions & 2 deletions pino.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ declare namespace pino {

interface TransportTargetOptions<TransportOptions = Record<string, any>> {
target: string
options: TransportOptions
level: LevelWithSilentOrString
options?: TransportOptions
level?: LevelWithSilentOrString
}

interface TransportBaseOptions<TransportOptions = Record<string, any>> {
Expand Down