Skip to content

Support Node.js v21 #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Oct 23, 2023
Merged

Support Node.js v21 #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support Node.js v21 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Oct 23, 2023
commit c89e0f64f0571aec4c7b9d9c0a5875279a48cc07
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
fail-fast: false
matrix:
os: [macOS-latest, windows-latest, ubuntu-latest]
node-version: [14, 16, 18, 19, 20]
node-version: [14, 16, 18, 19, 20, 21]
exclude:
- os: windows-latest
node-version: 14
Expand Down
2 changes: 1 addition & 1 deletion lib/proto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ function flush (cb) {

const stream = this[streamSym]

if ('flush' in stream) {
if (typeof stream.flush === 'function') {
stream.flush(cb || noop)
} else if (cb) cb()
}