Skip to content

Conversation

@mbtools
Copy link
Contributor

@mbtools mbtools commented Mar 22, 2024

Minor change to replaces a semver v1 notation (with leading v) with semver v2.

PS: The npm semver package most likely will deprecate semver v1 support in next major.

Minor change to replaces a semver v1 notation (with leading `v`) with semver v2.

PS: The npm semver package most likely will deprecate semver v1 support in next major.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I think it should be a caret.

@mbtools
Copy link
Contributor Author

mbtools commented Mar 31, 2024

Makes sense. Changed

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 06df1df into pinojs:master Mar 31, 2024
@mbtools mbtools deleted the patch-1 branch March 31, 2024 21:16
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants