Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,13 @@ function set (self, opts, rootLogger, level) {
configurable: true
})

if (!opts.transmit && self[level] === noop) {
return
if (self[level] === noop) {
if (!opts.transmit) return

const transmitLevel = opts.transmit.level || self.level
const transmitValue = rootLogger.levels.values[transmitLevel]
const methodValue = rootLogger.levels.values[level]
if (methodValue < transmitValue) return
}

// make sure the log format is correct
Expand Down
20 changes: 20 additions & 0 deletions test/browser-transmit.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -347,3 +347,23 @@ test('extracts correct bindings and raw messages over multiple transmits', ({ en

end()
})

test('does not log below configured level', ({ end, is }) => {
let message = null
const logger = pino({
level: 'info',
browser: {
write (o) {
message = o.msg
},
transmit: {
send () { }
}
}
})

logger.debug('this message is silent')
is(message, null)

end()
})