fix(browser): implement setBindings on browser logger#2403
Open
mibragimov wants to merge 1 commit intopinojs:mainfrom
Open
fix(browser): implement setBindings on browser logger#2403mibragimov wants to merge 1 commit intopinojs:mainfrom
mibragimov wants to merge 1 commit intopinojs:mainfrom
Conversation
The browser logger exposed Logger#setBindings in types, but the runtime implementation in browser.js did not define it. Calling setBindings on a browser logger caused a TypeError, even though setBindings is a supported Logger API in pino. Implement browser logger setBindings by storing the new bindings and rebuilding level methods so subsequent logs include updated binding objects. Add browser tests to verify setBindings applies bindings and can overwrite existing bindings. Fixes pinojs#2021
Member
|
CI is red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
setBindingsfor browser loggers soimport { pino } from "pino"logger instances support the documented Logger API and do not throw at runtime.Root Cause
setBindingsexists inLoggerExtrastypings (pino.d.ts) and is implemented for Node loggers vialib/proto.js, but browser runtime loggers created inbrowser.jsdid not definesetBindings.As a result, browser logger instances could throw:
TypeError: logger.setBindings is not a functionwhen using the named export path described in the issue.
Fix
logger.setBindings(bindings)tobrowser.js.setBindingsapplies bindings to logs.setBindingsagain overwrites previous bindings.setBindingsis exposed as a function on browser logger instances.Testing
npm run -s lintnode test/browser.test.jsCloses #2021