Adds imports in module decleration #130
Conversation
resolve #120 (comment) - divide `playground/src/context/theme-provider.tsx` to `theme-provider.tsx`, `theme-consumer.tsx` and `theme-context.ts`. - add the example for `useContext` to `playground/src/hooks/use-theme-context.tsx`.
resolve #120
Add examples for Context API
|
Just checked the contributing guide. Update my PR. |
piotrwitek
force-pushed
the
master
branch
2 times, most recently
from
9bfd6f2 to
ac58144
Compare
piotrwitek
left a comment
piotrwitek
left a comment
There was a problem hiding this comment.
Hey, I checked and it looks good! Could you please rebase your changes on master because I had to make some changes.
…edux-typescript-guide into import-decleration
|
@piotrwitek I did rebase with master, Looks like there is a declared value which is not getting used. Do want me to remove it and update the PR or it something related to your changes? |
…edux-typescript-guide into import-decleration
|
@arshadkazmi42 this was me, sorry for that. I fixed the build now, could you try again please? |
…edux-typescript-guide into import-decleration
|
@piotrwitek Done with rebasing. Build is passing now. Can you check it once if its required |
|
Hey @arshadkazmi42, your branch history is somehow broken, you have many duplicated commits. I would advise to create a new branch from master HEAD and then cherry-pick only 2 commits original commits with your changes. then submit another PR or just clean up your branch with push force. |
|
Let me create a fresh PR from latest master. |
3 participants
Fixes #63