Remove spaces from fntdata filename #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding fntdata file with spaces results into broken presentation
pastafari
reviewed
Sep 1, 2022
| rel: { | ||
| id: '', // populated in `genXml.makeXmlPresentationRels` | ||
| target: `fonts/${font.name}-${style.name}.fntdata`, | ||
| target: `fonts/${font.name.replace(/ /g,'')}-${style.name}.fntdata`, |
There was a problem hiding this comment.
I'm not sure how this works, because the rels would still refer to the name with spaces right?
Author
There was a problem hiding this comment.
no, the same target field is used when zipping happen
tjinauyeung
approved these changes
Sep 1, 2022
sam-pitch
approved these changes
Sep 2, 2022
seekuehe
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding fntdata file with spaces results into broken presentation -- fix