Skip to content

Conversation

@tjinauyeung
Copy link

@tjinauyeung tjinauyeung commented Nov 10, 2022

Resolves https://linear.app/pitch/issue/SWI-199/compilation-warning

pit dev complains about this docstring; possibly contains invalid characters, I've decided to remove in its entirety.

@linear
Copy link

linear bot commented Nov 10, 2022

SWI-199 Compilation warning

There's a compilation warning when building app.js, would be good if you can fix/suppress it.

[:app] Compiling ...
------ WARNING #1 - -----------------------------------------------------------
Resource: node_modules/pptxgenjs/dist/pptxgen.cjs.js:2568:12
Parse error. name not recognized due to syntax error.
--------------------------------------------------------------------------------
nil

An example is here https://app.circleci.com/pipelines/github/pitch-io/pitch-app/215194/workflows/1763d35f-96b8-4993-ab23-3196c4057879/jobs/2525630/parallel-runs/0/steps/0-117

@tjinauyeung tjinauyeung marked this pull request as ready for review November 10, 2022 07:47
@tjinauyeung tjinauyeung self-assigned this Nov 10, 2022
@tjinauyeung tjinauyeung force-pushed the fix-warnings branch 3 times, most recently from c28d15e to e82da77 Compare November 11, 2022 07:31
@tjinauyeung tjinauyeung merged commit 20cabc8 into pitch-main Nov 11, 2022
@tjinauyeung tjinauyeung deleted the fix-warnings branch November 11, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants