feat(ios): add gradation color support by orukahairuka · Pull Request #218 · plaidev/nubrick-ios

orukahairuka · 2025-08-18T06:47:12Z

iOSでのグラデーションカラーを実装

Copilot

Pull Request Overview

This PR implements gradient color support for iOS, adding the ability to render linear gradients in addition to solid colors for backgrounds, borders, and text.

Adds new ColorValue types to support both solid colors and linear gradients
Updates color parsing logic to handle the new gradient format while maintaining backward compatibility
Extends border and background configuration functions to apply gradient layers

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`ios/Nativebrik/Nativebrik/util/utils.swift`	Implements gradient color parsing, layer management, and configuration functions
`ios/Nativebrik/Nativebrik/generated.swift`	Adds new gradient-related data structures and enums
`ios/Nativebrik/Nativebrik/component/renderer/text.swift`	Updates text color handling to support new ColorValue format
`flutter/nativebrik_bridge/lib/schema/generated.dart`	Adds gradient support to Dart schema (auto-generated)
`android/nativebrik/src/main/java/com/nativebrik/sdk/schema/generated.kt`	Adds gradient support to Android schema (auto-generated)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

Copilot · 2025-08-18T06:48:19Z

+                view.layer.backgroundColor = color.cgColor
+                view.layer.sublayers?.filter { $0.name == "gradient-layer" }.forEach { $0.removeFromSuperlayer() }
+            case .linearGradient(let gradientLayer):
+                print("DEBUG: Applying gradient layer with bounds: \(view.bounds)")


Debug print statements should not be left in production code. Consider using proper logging or removing this statement.

Suggested change

print("DEBUG: Applying gradient layer with bounds: \(view.bounds)")

修正した

Copilot · 2025-08-18T06:48:19Z

+
+        if !colors.isEmpty {
+            gradientLayer.colors = colors
+            gradientLayer.locations = locations.count == colors.count ? locations : nil


[nitpick] The gradient stop position calculation uses a complex formula that may not distribute colors evenly. Consider simplifying this logic or adding a comment explaining the intended behavior.

Suggested change

gradientLayer.locations = locations.count == colors.count ? locations : nil

positionsSpecified.append(true)

} else {

positionsSpecified.append(false)

}

}

}

// Only set locations if all or none of the stops have explicit positions.

// If all have positions, use them. If none, distribute evenly. If mixed, let Core Animation handle it.

if !colors.isEmpty {

gradientLayer.colors = colors

if positionsSpecified.allSatisfy({ $0 }) && locations.count == colors.count {

// All stops have explicit positions

gradientLayer.locations = locations

} else if positionsSpecified.allSatisfy({ !$0 }) {

// None have explicit positions, distribute evenly

let count = colors.count

if count > 1 {

let evenLocations = (0..<count).map { NSNumber(value: Float($0) / Float(count - 1)) }

gradientLayer.locations = evenLocations

} else {

gradientLayer.locations = nil

}

} else {

// Mixed: let Core Animation distribute stops (do not set locations)

gradientLayer.locations = nil

}

提案されたものが複雑だと思われるため、対応しない

- Add gradient border support for simple border cases - Add view.clipsToBounds to prevent content overflow - Properly set gradient layer frame to match view bounds - Update both configureBorder and configureBorderWithRawData functions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

RyosukeCla · 2025-08-20T02:21:22Z

@orukahairuka generated のコードなんですけど、android と flutter の方は別の PR の方で commit してくださーい！！

This reverts commit 87677db.

orukahairuka · 2025-08-20T04:03:55Z

@RyosukeCla
generate.dartとgenerate.ktの差分を削除しました！

RyosukeCla · 2025-08-20T06:12:32Z

@orukahairuka nativebrik 本体の方の PR が固まってきてから、もう一度確認します！

…color

orukahairuka · 2025-08-27T08:31:35Z

@t-jimbo
レビューお願いします！

RyosukeCla · 2025-08-28T03:15:16Z

+
+        // Calculate direction vector (CSS coordinate system)
+        let dx = sin(radians)
+        let dy = -cos(radians)  // Y軸を反転（CSSは上が負、iOSは下が正）


コメント英語にしてくださーい！

英語にしました！

RyosukeCla · 2025-08-28T03:17:08Z

+        // CAGradientLayer: (0,0) is top-left, (1,1) is bottom-right
+
+        // Convert normalized value to radians
+        let degrees = angle * 360.0


angle が [0, 1] の範囲を超えてたら [0,1]にclipしてほしいです！

let clippedAngle = max(0, min(1, angle)) // Convert normalized value to radians let degrees = clippedAngle * 360.0

対応しました！

RyosukeCla · 2025-08-28T03:19:15Z

+                colors.append(parseColorToCGColor(color))
+
+                if let position = stop.position {
+                    locations.append(NSNumber(value: position))


position も [0,1]でclipしてください！

対応しました！

orukahairuka · 2025-08-28T08:38:59Z

@RyosukeCla 修正したので、レビューお願いします🙇

orukahairuka added 3 commits August 15, 2025 13:16

feat: gradation sdk

6e8decb

feat: generate struct

87677db

feat: color-gradation

9dc2ba7

orukahairuka requested a review from Copilot August 18, 2025 06:47

orukahairuka changed the title ~~Gradation color~~ feat: gradation-color Aug 18, 2025

Copilot AI reviewed Aug 18, 2025

View reviewed changes

orukahairuka changed the title ~~feat: gradation-color~~ feat: ios-gradation-color Aug 18, 2025

orukahairuka changed the title ~~feat: ios-gradation-color~~ feat(ios): add gradation color support Aug 18, 2025

fix: Delete comment

941228c

orukahairuka requested a review from t-jimbo August 18, 2025 06:59

orukahairuka and others added 4 commits August 19, 2025 16:08

fix: text gradation color bug

9a2e77b

fix: border gradation color

b08bd2e

fix: pod lib lint

f4ee09e

orukahairuka requested a review from RyosukeCla August 20, 2025 01:45

Revert "feat: generate struct"

005acdb

This reverts commit 87677db.

orukahairuka force-pushed the gradation-color branch from 005acdb to f4ee09e Compare August 20, 2025 03:00

fix: generated.swift

134c03f

orukahairuka and others added 9 commits August 26, 2025 12:34

generate swift

278ca9a

fix

af69083

Merge branch 'main' into gradation-color

29a9782

Merge remote-tracking branch 'origin/gradation-color' into gradation-…

da4f7c8

…color

border削除

d54c2ec

角

93a92d0

fix: comment

5f2df03

角まる

7a2b022

関数化

02e8573

orukahairuka added 2 commits August 27, 2025 14:54

変数名をbcに直す

e78802e

作成した関数を使用

85192cc

RyosukeCla reviewed Aug 28, 2025

View reviewed changes

orukahairuka and others added 3 commits August 28, 2025 14:33

fix: コメントを英語にした

accaea5

クリップを修正

366a5c4

Merge branch 'main' into gradation-color

e434895

-            gradientLayer.locations = locations.count == colors.count ? locations : nil
+                    positionsSpecified.append(true)
+                } else {
+                    positionsSpecified.append(false)
+                }
+            }
+        }
+        // Only set locations if all or none of the stops have explicit positions.
+        // If all have positions, use them. If none, distribute evenly. If mixed, let Core Animation handle it.
+        if !colors.isEmpty {
+            gradientLayer.colors = colors
+            if positionsSpecified.allSatisfy({ $0 }) && locations.count == colors.count {
+                // All stops have explicit positions
+                gradientLayer.locations = locations
+            } else if positionsSpecified.allSatisfy({ !$0 }) {
+                // None have explicit positions, distribute evenly
+                let count = colors.count
+                if count > 1 {
+                    let evenLocations = (0..<count).map { NSNumber(value: Float($0) / Float(count - 1)) }
+                    gradientLayer.locations = evenLocations
+                } else {
+                    gradientLayer.locations = nil
+                }
+            } else {
+                // Mixed: let Core Animation distribute stops (do not set locations)
+                gradientLayer.locations = nil
+            }

Conversation

orukahairuka commented Aug 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

orukahairuka Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

orukahairuka Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

RyosukeCla commented Aug 20, 2025

Uh oh!

orukahairuka commented Aug 20, 2025

Uh oh!

RyosukeCla commented Aug 20, 2025

Uh oh!

orukahairuka commented Aug 27, 2025

Uh oh!

RyosukeCla Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

orukahairuka Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

RyosukeCla Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

orukahairuka Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

RyosukeCla Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

orukahairuka Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orukahairuka commented Aug 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

orukahairuka Aug 28, 2025 •

edited

Loading