Skip to content

Conversation

@BradNeuberg
Copy link
Contributor

Feedback from Jonathan Evens originally for the changes.

Feedback from Jonathan Evens originally for the changes.
"In the building construction feed, a change result contains a geographic polygon or grid cell that represents the footprint of a contiguous area where we have detected building construction. Thus, these polygons represent general built-up area, and may not identify individual buildings. They may be a group of small buildings clumped together, or a new adjacent wing of an existing building.\n",
"\n",
"In the case of the road construction feed, the change results contain a linestring, instead of a polygon. This linestring represents the skeleton of a road segment that has been constructed. \n",
"In the case of the road construction feed, the change results also contain a polygon or grid cell. It represents the footprint of a contiguous area where a road segment has been constructed.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we share any more detail about what constitutes a "road segment" here?

"#subscription_id = \"dd2878b3-eaf0-4cff-b7f9-7a39d6f460a5\" # Monthly Building Construction\n",
"subscription_id = \"dbfcd806-b44d-45d5-b84d-3566a80eca27\" # Monthly Road Construction\n",
"#subscription_id = \"635c57d3-b921-453f-8e79-70929e50a470\" # Monthly Building Construction\n",
"subscription_id = \"8869cf69-9596-47ab-8d94-52b94fcf528e\" # Monthly Road Construction\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade :)

@strixcuriosus
Copy link
Contributor

LGTM! Nice digram explaining cadence and lag. Adding an animation might be useful, too.

@strixcuriosus strixcuriosus self-assigned this Sep 18, 2020
@strixcuriosus strixcuriosus removed their assignment Sep 18, 2020
@BradNeuberg
Copy link
Contributor Author

Thanks @strixcuriosus for the feedback! We are trying to keep this PR really focused and bring all this Jupyter notebook work to a close, so holding off on any extensive changes for now like a new animation so that we can get this out the door.

@BradNeuberg BradNeuberg merged commit c8678e4 into planetlabs:master Sep 18, 2020
@BradNeuberg BradNeuberg deleted the cd-notebooks-fixes-part-2 branch September 18, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants