Skip to content

Conversation

@tazmaniax
Copy link
Contributor

@tazmaniax tazmaniax commented Jun 18, 2022

Updates Play1 framework dependencies. This updates Eclipse JDT Core to v3.30.0 that supports Java 18 source code.

All tests pass.

@tazmaniax
Copy link
Contributor Author

@xael-fry @asolntsev @tomparle FYI

@tazmaniax
Copy link
Contributor Author

@xael-fry FirePhoque changes have been moved to #1418

@xabolcs
Copy link
Contributor

xabolcs commented Jun 22, 2022

@tazmaniax would you mind squashing your commits (as fix-up commits to the first) in this PR?

@tazmaniax
Copy link
Contributor Author

@xabolcs not sure I understand what you're asking for or the value, can you explain? Don't you typically just squash the commits at the point of the merge?

@xabolcs
Copy link
Contributor

xabolcs commented Jun 22, 2022

I do in my own projects, but GitHub here doesn't:

$ git log --graph --oneline 
*   9acc2209e (HEAD -> master, upstream/master) Merge pull request #1416 from xael-fry/prepare-1.7.1-release
|\  
| * 629ccd3a1 * Prepare release 1.7.1
* |   629aee531 Merge pull request #1409 from aleksandy/correct-check-of-java-version-before-startup
|\ \  
| |/  
|/|   
| * 0dfa87438 update check of java version
* |   7cc3fbb33 Merge pull request #1411 from sp00m/patch-1
|\ \  
| * | d9cfc33ed [#1411] Update framework/src/play/cache/MemcachedImpl.java
| * | 672e3c5e3 Do not overwrite system property net.spy.log.LoggerImpl
| |/  
* |   2478bd291 Merge pull request #1408 from aleksandy/fix/1405
|\ \  
| |/  
|/|   
| * 72e331fd1 #1405: replace HashMap be ConcurrentHashMap
|/  
*   ed2622db5 Merge pull request #1406 from holajsh/1403_groovy_compilation_fixes
|\  
| * 1dbaf5cec [#1403] 🐛 Add a comment to explain why reflection is used instead of Groovy native methods
| * 5d057d4fe [#1403] 🐛 Fix Groovy compilation unit that tries to write in application root folder
|/  
*   20d87441b Merge pull request #1397 from tazmaniax/third_party_dependency_update_20220403
|\  
| * 4e9b3d42b Third party dependency update 20220403
* |   4a41d32cf Merge pull request #1400 from jacol84/run-on-win
|\ \  
| * | 97a8c2c8c fixed #1399 no initialization playHome
* | |   b1729b1eb Merge pull request #1402 from holajsh/1401_python3_module_fixes
|\ \ \  
| |/ /  
|/| |   
| * | 547bf8838 [#1401] 🐛 Fix python3 incompatibilities in module manipulation code
|/ /  
* / 24a09331b (tag: 1.7.0) fix base version to 1.7.x
|/  
*   f31919cd6 Merge pull request #1396 from xael-fry/1.7.0_documentation
|\  
| * d9857b27e [1.7.0] add releasenotes-1.7.0.textile
|/  
*   6b17d8057 Merge pull request #1394 from xael-fry/pr_1355_v3
|\  
| * d99cf348e [#1355] fix ssl config test
| * d1da5ee3b [#1355] test kill play
| * 2f8084574 [#1355] remove python 2
| * f4abb4ddd [#1355]
| * b5d82444c [#1355] fix python path for windows
| * 5bd109a20 fix builtins lib import deprecated in python 3
| * 3a4d69a90 fixed incorrect lib structure for python tests
| * 5d421458b change POpen parameter to be compatible with all 3.x python versions
| * 994e5a1df upgrade build file to use python 3 for ant tests on github
| * ca81a3f40 upgrade latest changes from master to python 3 syntax

(And I'm just a Play! 1 fan here. 🙂 )

@xael-fry xael-fry added the dependencies Pull requests that update a dependency file label Jul 3, 2022
@xael-fry xael-fry added this to the 1.8.0 milestone Jul 3, 2022
@xael-fry
Copy link
Member

xael-fry commented Jul 3, 2022

LGTM

@xael-fry xael-fry merged commit f0f6e3e into playframework:master Jul 3, 2022
@xael-fry
Copy link
Member

xael-fry commented Jul 3, 2022

Merge it in master
Thanks @tazmaniax

@Alexandermjos
Copy link

Will this be released in 1.8.0 by September 26, 2022 which is target date of 1.8.0?
I am upgrading to 1.7.1 next week, but if 1.8.0 is ready by September 26, 2022 I will just wait for 1.8.0

@tazmaniax
Copy link
Contributor Author

There is a follow on dependency update here #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants