Skip to content

Conversation

@aleksandy
Copy link
Contributor

Just some cleanup no new functionality

@aleksandy
Copy link
Contributor Author

@xael-fry, could you review and merge this PR?

@aleksandy aleksandy force-pushed the cleanup branch 2 times, most recently from 0714fc0 to 7865660 Compare October 3, 2025 19:52
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xael-fry xael-fry self-assigned this Nov 9, 2025
@xael-fry xael-fry self-requested a review November 9, 2025 08:02
@aleksandy aleksandy force-pushed the cleanup branch 2 times, most recently from e81aede to 6e6f7dd Compare November 10, 2025 18:12
@aleksandy aleksandy force-pushed the cleanup branch 2 times, most recently from c629e3a to 3f6e4dc Compare November 11, 2025 19:03
* use java.util.Base64 instead of third-party implementation;
* extract copy-pasted code into common method
* remove redundant static clauses@FunctionalInterface;
* add standard functional interfaces to own realization;
* remove unused field from Promise;
* use emptyIterator() instead of emptyList().iterator().
* remove redundant null-checks
* make Oops exception private
* use lambda instead of ModuleFilter
@xael-fry
Copy link
Member

xael-fry commented Nov 15, 2025

@aleksandy is it ready for review as you always forced pushed and add new commit ?
I will put it in draft and let you work on it.
Thanks

@xael-fry xael-fry changed the title Cleanup DRAFT: Cleanup Nov 15, 2025
@xael-fry xael-fry marked this pull request as draft November 15, 2025 07:42
@xael-fry xael-fry changed the title DRAFT: Cleanup Cleanup Nov 15, 2025
@xael-fry xael-fry added this to the 1.11.0 milestone Nov 15, 2025
@xael-fry xael-fry marked this pull request as ready for review November 15, 2025 08:38
@xael-fry xael-fry merged commit 6405e6c into playframework:master Nov 15, 2025
10 checks passed
@xael-fry xael-fry linked an issue Nov 15, 2025 that may be closed by this pull request
@xael-fry
Copy link
Member

xael-fry commented Nov 15, 2025

Merged
Thanks @aleksandy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transitiveDependencies in dependencies.conf doesn't work

3 participants