Skip to content

631 ci fix #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edublancas merged 3 commits into from
Jun 20, 2023
Merged

631 ci fix #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f881c2
ci fix 631
AnirudhVIyer Jun 20, 2023
6869e25
ci fix duckdb
AnirudhVIyer Jun 20, 2023
454d74b
ci fix duckdb lint
AnirudhVIyer Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 0.7.10dev

* [Doc] Document --persist-replace in API section (#539)
* [Fix] Fixed CI issue by updating `invalid_connection_string_duckdb` in `test_magic.py` (#631)

## 0.7.9 (2023-06-19)

Expand Down
3 changes: 1 addition & 2 deletions src/tests/test_magic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,7 @@ def test_error_on_invalid_connection_string_with_possible_typo(ip_empty, clean_c
An error happened while creating the connection: connect(): incompatible function arguments. The following argument types are supported:
1. (database: str = ':memory:', read_only: bool = False, config: dict = None) -> duckdb.DuckDBPyConnection

Invoked with: kwargs: host='invalid_db'.
Invoked with: kwargs: host='invalid_db', config={{}}.

Perhaps you meant to use the 'duckdb' db
To find more information regarding connection: https://jupysql.ploomber.io/en/latest/integrations/duckdb.html
Expand All @@ -1104,7 +1104,6 @@ def test_error_on_invalid_connection_string_with_possible_typo(ip_empty, clean_c

def test_error_on_invalid_connection_string_duckdb(ip_empty, clean_conns):
result = ip_empty.run_cell("%sql duckdb://invalid_db")

assert invalid_connection_string_duckdb.strip() == str(result.error_in_exec)
assert isinstance(result.error_in_exec, UsageError)

Expand Down