Skip to content

Add types from @types/plotly.js-dist-min, Typing update, Export PlotlyViaWindow and PlotlyViaCDN #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add types from @types/plotly.js-dist-min, Typing update, Export PlotlyViaWindow and PlotlyViaCDN #288

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a8d153
Add types from @types/plotly.js-dist-min
bzh2610 Oct 2, 2025
d46f753
Bump version number
bzh2610 Oct 2, 2025
67a78e6
@types as dev-dep
bzh2610 Oct 2, 2025
77c4b77
fix test, after jasmine reset api change
bzh2610 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test, after jasmine reset api change
  • Loading branch information
@bzh2610
bzh2610 committed Oct 2, 2025
commit 77c4b773c6a5a067413ceaccb73fa12c96b82c43
11 changes: 10 additions & 1 deletion projects/plotly/src/lib/plotly.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,21 @@ describe('PlotlyComponent', () => {
await component.createPlot();
await fixture.whenStable();

spyOn(PlotlyJS.Plots, 'resize').and.callThrough();
const resizeSpy = spyOn(PlotlyJS.Plots, 'resize').and.callThrough();

window.dispatchEvent(new Event('resize'));
await fixture.whenStable();

expect(PlotlyJS.Plots.resize).toHaveBeenCalled();
resizeSpy.calls.reset();

fixture.destroy();
await fixture.whenStable();

window.dispatchEvent(new Event('resize'));
await fixture.whenStable();

expect(resizeSpy).not.toHaveBeenCalled();
});


Expand Down