Skip to content

Flat extend input traces on addTraces #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 5 commits into from
Nov 21, 2016
Merged

Flat extend input traces on addTraces #1175

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1058366
Clone input trace
dy Nov 11, 2016
ea8ce86
Ignore line ending style
dy Nov 11, 2016
fa18648
Fix typo
dy Nov 11, 2016
ecd795a
test: add case for addTraces with exising data/traces
etpinard Nov 21, 2016
7e4c5c1
lint
etpinard Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@dy @etpinard
dy authored and etpinard committed Nov 21, 2016
commit fa18648b20ed97fa7f54744a835beb9a919c0b16
2 changes: 1 addition & 1 deletion src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ Plotly.addTraces = function addTraces(gd, traces, newIndices) {
traces = [traces];
}

// make sure traces does not repeat existing ones
// make sure traces do not repeat existing ones
traces = traces.map(function(trace) {
return Lib.extendFlat({}, trace);
});
Expand Down