Skip to content

Bring back click events [fixes #173] #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 3 commits into from
Jan 11, 2016
Merged

Bring back click events [fixes #173] #174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210acac
partial fix for click events:
etpinard Jan 11, 2016
40cc585
bring fx.unhover call to onDone handler
etpinard Jan 11, 2016
026e16e
move fx.unhover call to onMove handler
etpinard Jan 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bring fx.unhover call to onDone handler
  • Loading branch information
@etpinard
etpinard committed Jan 11, 2016
commit 40cc58508dc97c84006a1a32cc3bc72f3e681ea9
2 changes: 1 addition & 1 deletion src/plots/cartesian/graph_interact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
clearSelect();
}
else if(dragModeNow === 'select' || dragModeNow === 'lasso') {
fx.unhover(gd); // we want a clear plot for dragging
prepSelect(e, startX, startY, dragOptions, dragModeNow);
}
}
Expand Down Expand Up @@ -2060,6 +2059,7 @@ fx.dragElement = function(options) {

if(!gd._dragging) {
gd._dragged = false;
fx.unhover(gd);
return;
}
gd._dragging = false;
Expand Down