-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Trace Module Functionality #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
7e41625
b716568
d639a93
356d0af
7a22cff
2ac3605
6e53762
46b83d8
23519f0
71db785
06640b4
4507ec5
6bd4c5b
b4793c1
48b3803
5a2da5c
4fe8440
e46373e
a7fda91
43156a3
03232e0
28def12
f831b66
4994256
6dd9a41
823ae72
75dc282
b8864eb
5f26169
a693bb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,22 +9,8 @@ | |
|
|
||
| 'use strict'; | ||
|
|
||
| var Plots = require('../../plots/plots'); | ||
|
|
||
| var Bar = {}; | ||
|
|
||
| Plots.register(Bar, 'bar', | ||
| ['cartesian', 'bar', 'oriented', 'markerColorscale', 'errorBarsOK', 'showLegend'], { | ||
| description: [ | ||
| 'The data visualized by the span of the bars is set in `y`', | ||
| 'if `orientation` is set th *v* (the default)', | ||
| 'and the labels are set in `x`.', | ||
|
|
||
| 'By setting `orientation` to *h*, the roles are interchanged.' | ||
| ].join(' ') | ||
| } | ||
| ); | ||
|
|
||
| Bar.attributes = require('./attributes'); | ||
| Bar.layoutAttributes = require('./layout_attributes'); | ||
| Bar.supplyDefaults = require('./defaults'); | ||
|
|
@@ -37,4 +23,15 @@ Bar.plot = require('./plot'); | |
| Bar.style = require('./style'); | ||
| Bar.hoverPoints = require('./hover'); | ||
|
|
||
| Bar._categories = ['cartesian', 'bar', 'oriented', 'markerColorscale', 'errorBarsOK', 'showLegend']; | ||
| Bar._type = 'bar'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I used Though traces are identified by type. Not sure what's best. |
||
| Bar._meta = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another minor point, do we need these None of the trace modules are public (as in standalone objects that users could use directly). Why do need to make a distinction between e.g the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. I used the |
||
| description: [ | ||
| 'The data visualized by the span of the bars is set in `y`', | ||
| 'if `orientation` is set th *v* (the default)', | ||
| 'and the labels are set in `x`.', | ||
| 'By setting `orientation` to *h*, the roles are interchanged.' | ||
| ].join(' ') | ||
| }; | ||
|
|
||
| module.exports = Bar; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner than my
exports.stack. 🍻