-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
German translation #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
German translation #2217
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
78ddef5
Translation local.de
JonasGutermuth d4ae8bd
Typos
JonasGutermuth 966bf87
Update de.js
JonasGutermuth 09e6294
Solving lint problems
JonasGutermuth c844c24
Removing wrong spaces
JonasGutermuth aaf6bc3
Update de.js
JonasGutermuth 3aa7cfc
Format comments
JonasGutermuth 2690898
Update de.js
JonasGutermuth 33ef2ba
Merge branch 'master' into german
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update de.js
- Loading branch information
commit 269089847210fee3a82694207cb79568e8c10754
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdugge:
'IE unterstützt nur svg-Dateien. Format wird zu svg gewechselt.'
@JonasGutermuth:
Wikipedia uses SVG instead of svg. The double space is also in english.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out the double space - Since this gets displayed with normal whitespace rules, only one space is actually shown, but it needs the spaces to match for translation. I'll leave it for now, but may strip out the second space (from the source and any translations) at some point.
re: capitalization of SVG - I don't have a strong opinion for English (anyone else feel strongly that we should capitalize it?), but we should probably keep SVG and PNG consistent within any given locale, so should we also use
'Download als PNG'above?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Wikipedia uses also PNG instead of png. So change both to capital letters?