Skip to content

Plots.resize returns a Promise #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2016
Merged

Plots.resize returns a Promise #253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb0a2a
Plots.resize returns a Promise
Feb 12, 2016
c336dae
un-linted
Feb 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Plots.resize returns a Promise 
As the resize operation will modify the size of the plot only after a
timeout, if you call resize and then immediately do something based on
the current plot size, you'll get the "old" size. This fixes it.
  • Loading branch information
Alessandro Burato committed Feb 12, 2016
commit fdb0a2a0830370533684cebbba4a733e8dd768fe
30 changes: 17 additions & 13 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,23 +232,27 @@ plots.redrawText = function(gd) {
};

// resize plot about the container size
plots.resize = function(gd) {
if(!gd || d3.select(gd).style('display') === 'none') return;
plots.resize = function (gd) {
if (!gd || d3.select(gd).style('display') === 'none') return;

if(gd._redrawTimer) clearTimeout(gd._redrawTimer);
return new Promise(function (resolve) {

if (gd._redrawTimer) clearTimeout(gd._redrawTimer);

gd._redrawTimer = setTimeout(function() {
if((gd._fullLayout || {}).autosize) {
// autosizing doesn't count as a change that needs saving
var oldchanged = gd.changed;
gd._redrawTimer = setTimeout(function () {
if ((gd._fullLayout || {}).autosize) {
// autosizing doesn't count as a change that needs saving
var oldchanged = gd.changed;

// nor should it be included in the undo queue
gd.autoplay = true;
// nor should it be included in the undo queue
gd.autoplay = true;

Plotly.relayout(gd, {autosize: true});
gd.changed = oldchanged;
}
}, 100);
Plotly.relayout(gd, { autosize: true });
gd.changed = oldchanged;
resolve();
}
}, 100);
});
};


Expand Down