Skip to content

Add support for multiple subplots to fx.hover() #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2016
Merged

Add support for multiple subplots to fx.hover() #301

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db44a5b
Add support for multiple subplots to fx.hover()
Feb 29, 2016
7e55391
Switch to use Array.isArray to check subplot argument. Cleanup to sat…
Mar 1, 2016
ba01b79
Update to latest master
Mar 1, 2016
cddba4e
Some more formatting fixups for lint
Mar 1, 2016
57d669d
Add unit tests for stacked subplots with both shared x and y axes
Mar 5, 2016
a2164e4
Add baseline image for stacked_subplots_shared_yaxis.json
Mar 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some more formatting fixups for lint
  • Loading branch information
John Soklaski committed Mar 1, 2016
commit cddba4e5d42b50bba303debf71f1aabd5625549c
6 changes: 3 additions & 3 deletions src/plots/cartesian/graph_interact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ function hover(gd, evt, subplot) {
subplot :
// list of all overlaid subplots to look at
[subplot].concat(plotinfo.overlays
.map(function(pi){ return pi.id; })),
.map(function(pi) { return pi.id; })),

xaArray = subplots.map(function(spId) {
return Plotly.Axes.getFromId(gd, spId, 'x');
Expand Down Expand Up @@ -876,7 +876,7 @@ function createHoverText(hoverData, opts) {

// first create the objects
var hoverLabels = container.selectAll('g.hovertext')
.data(hoverData,function(d){
.data(hoverData,function(d) {
return [d.trace.index,d.index,d.x0,d.y0,d.name,d.attr,d.xa,d.ya ||''].join(',');
});
hoverLabels.enter().append('g')
Expand Down Expand Up @@ -1050,7 +1050,7 @@ function hoverAvoidOverlaps(hoverData, ax) {

// make groups of touching points
pointgroups = hoverData
.map(function(d,i){
.map(function(d,i) {
var axis = d[ax];
return [{
i: i,
Expand Down