Skip to content

Introducing densitymapbox traces #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Introducing densitymapbox traces #3993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e15d81
add densitymapbox attributes
etpinard Jun 28, 2019
91a9bc4
implement densitymapbox
etpinard Jun 28, 2019
4f42d1b
add densitymapbox jasmine tests
etpinard Jun 28, 2019
4299857
add :three: densitymapbox mocks
etpinard Jun 28, 2019
1add90e
remove layers from last to first
etpinard Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove layers from last to first
  • Loading branch information
@etpinard
etpinard committed Jun 28, 2019
commit 1add90efdfb7d930ff3c0c880199cdeef776b5e2
2 changes: 1 addition & 1 deletion src/traces/choroplethmapbox/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ proto._removeLayers = function() {
var map = this.subplot.map;
var layerList = this.layerList;

for(var i = 0; i < layerList.length; i++) {
for(var i = layerList.length - 1; i >= 0; i--) {
map.removeLayer(layerList[i][1]);
}
};
Expand Down
2 changes: 1 addition & 1 deletion src/traces/densitymapbox/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ proto._removeLayers = function() {
var map = this.subplot.map;
var layerList = this.layerList;

for(var i = 0; i < layerList.length; i++) {
for(var i = layerList.length - 1; i >= 0; i--) {
map.removeLayer(layerList[i][1]);
}
};
Expand Down