Skip to content

Don't draw ticks on tick subplots when mirror:'all' #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Don't draw ticks on tick subplots when mirror:'all' #4140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6e919
add failing mock for #4136
etpinard Aug 20, 2019
cc19178
fix #4136 - don't draw ticks corresponding to _linepositions
etpinard Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add failing mock for #4136
  • Loading branch information
@etpinard
etpinard committed Aug 20, 2019
commit 8f6e919fd5b23e27ca85f2f3145061cfd27fb85b
Binary file added test/image/baselines/mirror-all-vs-allticks.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
57 changes: 57 additions & 0 deletions test/image/mocks/mirror-all-vs-allticks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
{
"data": [
{
"x": [1, 2, 3],
"y": [4, 5, 6]
},
{
"x": [20, 30, 40],
"y": [50, 60, 70],
"xaxis": "x2"
},
{
"x": [1, 2, 3],
"y": [4, 5, 6],
"yaxis": "y2"
},
{
"x": [20, 30, 40],
"y": [50, 60, 70],
"xaxis": "x2",
"yaxis": "y2"
}
],
"layout": {
"showlegend": false,
"grid": {
"rows": 2,
"columns": 2
},
"xaxis": {
"title": {"text": "mirror:all"},
"ticks": "outside",
"showline": true,
"mirror": "all"
},
"xaxis2": {
"title": {"text": "mirror:allticks"},
"ticks": "outside",
"showline": true,
"mirror": "allticks"
},
"yaxis": {
"title": {"text": "mirror:all"},
"ticks": "outside",
"showline": true,
"zeroline": false,
"mirror": "all"
},
"yaxis2": {
"title": {"text": "mirror:allticks"},
"ticks": "outside",
"showline": true,
"zeroline": false,
"mirror": "allticks"
}
}
}