Skip to content

Adapt default axis ranges to rangemode #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Adapt default axis ranges to rangemode #4171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix #4137 - adapt default axis ranges to *rangemode*' 
... so that even if no `_extremes` stash get filled in,
    ax.rangemode still as an effect.
  • Loading branch information
@etpinard
etpinard committed Sep 6, 2019
commit 06ee3c0e7d7849208d03a7b2ca243e1c7fedded6
4 changes: 4 additions & 0 deletions src/plots/cartesian/set_convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,10 @@ module.exports = function setConvert(ax, fullLayout) {
// make sure we don't later mutate the defaults
dflt = dflt.slice();

if(ax.rangemode === 'tozero' || ax.rangemode === 'nonnegative') {
dflt[0] = 0;
}

if(!range || range.length !== 2) {
Lib.nestedProperty(ax, rangeAttr).set(dflt);
return;
Expand Down
19 changes: 19 additions & 0 deletions test/jasmine/tests/axes_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,25 @@ describe('Test axes', function() {
_assertMatchingAxes(['xaxis3', 'yaxis3'], true, [-1, 6]);
_assertMatchingAxes(['xaxis4', 'yaxis4'], false, [-1, 3]);
});

it('should adapt default axis ranges to *rangemode*', function() {
layoutIn = {
xaxis: {rangemode: 'tozero'},
yaxis: {rangemode: 'nonnegative'},
xaxis2: {rangemode: 'nonnegative'},
yaxis2: {rangemode: 'tozero'}
};
layoutOut._subplots.cartesian.push('x2y2');
layoutOut._subplots.xaxis.push('x2');
layoutOut._subplots.yaxis.push('y2');

supplyLayoutDefaults(layoutIn, layoutOut, fullData);

expect(layoutOut.xaxis.range).withContext('xaxis range').toEqual([0, 6]);
expect(layoutOut.xaxis2.range).withContext('xaxis2 range').toEqual([0, 6]);
expect(layoutOut.yaxis.range).withContext('yaxis range').toEqual([0, 4]);
expect(layoutOut.yaxis2.range).withContext('yaxis2 range').toEqual([0, 4]);
});
});

describe('constraints relayout', function() {
Expand Down