Skip to content

Fix tiny zoombox behavior #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Fix tiny zoombox behavior #4188

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2d4e9
fix typos in cartesian_interact suite
etpinard Sep 13, 2019
1c12dba
:hocho: 2*MINDRAG requirement for zoomboxes to lead to relayout
etpinard Sep 13, 2019
61b88e9
fixup click-to-select in dragmode:'zoom' test
etpinard Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup click-to-select in dragmode:'zoom' test 
- that drag(LASSO_PATH) call used to lead a no zoom,
  so this test did not properly check for seletedpoints
  persistence after zoom
  • Loading branch information
@etpinard
etpinard committed Sep 13, 2019
commit 61b88e95356ba53f91855a57d04abd9b9a7a2276
14 changes: 10 additions & 4 deletions test/jasmine/tests/select_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,17 +437,23 @@ describe('Click-to-select', function() {
assertSelectedPoints([7, 35]);
return _clickPt(mock14Pts[7], { shiftKey: true });
})
.then(function() {
assertSelectedPoints(35);
drag(LASSO_PATH);
})
.then(function() {
assertSelectedPoints(35);
_clickPt(mock14Pts[35], { shiftKey: true });
return deselectPromise;
})
.then(function() {
assertSelectionCleared();
return _clickPt(mock14Pts[7], { shiftKey: true });
})
.then(function() {
assertSelectedPoints(7);
drag([[110, 100], [300, 300]]);
})
.then(delay(100))
.then(function() {
// persist after zoombox
assertSelectedPoints(7);
})
.catch(failTest)
.then(done);
Expand Down