Skip to content

Fix scattergl hover over nulls #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix scattergl hover over nulls #4213

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
880b7e9
fix #4212 - create new pointData object instead extending original
etpinard Sep 23, 2019
5d9bd0a
:hocho: obsolete if-else clause
etpinard Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
🔪 obsolete if-else clause 
- post #3578 all scattergl traces either set a `tree` or
  and `ids` array during the calc step.
  • Loading branch information
@etpinard
etpinard committed Sep 23, 2019
commit 5d9bd0ada0e3d195b2b966a63fe25a425646b26b
4 changes: 2 additions & 2 deletions src/traces/scattergl/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ function hoverPoints(pointData, xval, yval, hovermode) {
Math.max(xl, xr), Math.max(yl, yr)
);
}
} else if(stash.ids) {
} else {
ids = stash.ids;
} else return [pointData];
}

// pick the id closest to the point
// note that point possibly may not be found
Expand Down