-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Keep orthographic zoom scales in fullLayout #4292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4a649f0
record glplot aspect in fullLayout aspectratio
archmoj fe19e47
Store direct aspectratio edits and emit relayout
archmoj b92230a
Save camera and aspectratio only if they change before redraw the scene
archmoj d825c0e
improve relayout update object - now depends on changed parameter
archmoj d486dcd
correct initializeGLPlot argument
archmoj 496059c
simplify gl3d pixelRatio pass
archmoj e4a30be
add new tests to cover both orthographic and perspective cases
archmoj 3b28fae
add few more tests to lock down the orthographic relayout issue
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
add few more tests to lock down the orthographic relayout issue
- Loading branch information
commit 3b28faef2ddd72d1ce6f6d2812f5b1f01917075f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.