Skip to content

Plots.resize: promises should always be resolved #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Plots.resize: promises should always be resolved #4392

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
deb32ff
Plots.resize: reject old promises
antoinerg Nov 29, 2019
040d6ac
Plots.resize: resolve old promises
antoinerg Dec 4, 2019
5ee431e
Plots.resize: only resolve if a new request hasn't been queued
antoinerg Dec 4, 2019
5e71cff
Plots.resize: delete old promise resolver if present
antoinerg Dec 5, 2019
14f518f
Plots.resize: improve test
antoinerg Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Plots.resize: delete old promise resolver if present
  • Loading branch information
@antoinerg
antoinerg committed Dec 5, 2019
commit 5e71cffe386bba63078e735476ba1c57b0189163
5 changes: 4 additions & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ plots.resize = function(gd) {
Registry.call('relayout', gd, {autosize: true}).then(function() {
gd.changed = oldchanged;
// Only resolve if a new call hasn't been made!
if(gd._resolveResize === resolve) resolve(gd);
if(gd._resolveResize === resolve) {
delete gd._resolveResize;
resolve(gd);
}
});
}, 100);
});
Expand Down