Skip to content

sankey: fix position of link hover labels in vertical orientation #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2019
Merged

sankey: fix position of link hover labels in vertical orientation #4404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d45161
sankey: fix position of link hover labels in vertical orientation
antoinerg Dec 3, 2019
1c29be9
sankey_test: increase position tolerance to run on CI
antoinerg Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
sankey_test: increase position tolerance to run on CI
  • Loading branch information
@antoinerg
antoinerg committed Dec 3, 2019
commit 1c29be9c0f35bb29b7a8819e2ee4863d6ed4cdd0
8 changes: 4 additions & 4 deletions test/jasmine/tests/sankey_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,8 +792,8 @@ describe('sankey tests', function() {

var g = d3.select('.hovertext');
var pos = g.node().getBoundingClientRect();
expect(pos.x).toBeCloseTo(555, 0, 'it should have correct x position');
expect(pos.y).toBeCloseTo(196, 0, 'it should have correct y position');
expect(pos.x).toBeCloseTo(555, -1.5, 'it should have correct x position');
expect(pos.y).toBeCloseTo(196, -1.5, 'it should have correct y position');
return Plotly.restyle(gd, 'orientation', 'v');
})
.then(function() {
Expand All @@ -806,8 +806,8 @@ describe('sankey tests', function() {

var g = d3.select('.hovertext');
var pos = g.node().getBoundingClientRect();
expect(pos.x).toBeCloseTo(279, 0, 'it should have correct x position');
expect(pos.y).toBeCloseTo(500, 0, 'it should have correct y position');
expect(pos.x).toBeCloseTo(279, -1.5, 'it should have correct x position');
expect(pos.y).toBeCloseTo(500, -1.5, 'it should have correct y position');
})
.catch(failTest)
.then(done);
Expand Down