Skip to content

Make surface contour highlights on hover toggleable #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2016
Merged

Make surface contour highlights on hover toggleable #459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
39c8ece
fix :camel: typo in surface contours attributes:
etpinard Apr 21, 2016
173f13e
make surface contours and scene spikes use Color.defaultLine
etpinard Apr 21, 2016
07f60e3
add / update surface attribute descriptions
etpinard Apr 21, 2016
68bb949
rm useless field (not found in gl-surface3d)
etpinard Apr 21, 2016
78d8a49
pass 'contours.?.highlight' to gl-surface3d enableDynamic
etpinard Apr 21, 2016
d16199c
lint
etpinard Apr 21, 2016
ab2b9e8
add comment about smarter surface showscale default
etpinard Apr 21, 2016
5f7293d
fix linting errors
etpinard Apr 21, 2016
3042c13
stub out gl3d.plot in plot api test,
etpinard Apr 21, 2016
07f318a
update surface defaults tests
etpinard Apr 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make surface contours and scene spikes use Color.defaultLine
  • Loading branch information
@etpinard
etpinard committed Apr 21, 2016
commit 173f13e02b569bc00f78bfa3e7214fb127de254b
4 changes: 2 additions & 2 deletions src/plots/gl3d/layout/axis_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

'use strict';


var Color = require('../../../components/color');
var axesAttrs = require('../../cartesian/layout_attributes');
var extendFlat = require('../../../lib/extend').extendFlat;

Expand Down Expand Up @@ -43,7 +43,7 @@ module.exports = {
spikecolor: {
valType: 'color',
role: 'style',
dflt: 'rgb(0,0,0)',
dflt: Color.defaultLine,
description: 'Sets the color of the spikes.'
},
showbackground: {
Expand Down
5 changes: 3 additions & 2 deletions src/traces/surface/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

'use strict';

var Color = require('../../components/color');
var colorscaleAttrs = require('../../components/colorscale/attributes');
var extendFlat = require('../../lib/extend').extendFlat;

Expand Down Expand Up @@ -44,7 +45,7 @@ function makeContourAttr(axLetter) {
color: {
valType: 'color',
role: 'style',
dflt: '#000'
dflt: Color.defaultLine,
Copy link
Contributor Author

@etpinard etpinard Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This required updating on baseline image ⬇️.

},
usecolormap: {
valType: 'boolean',
Expand All @@ -66,7 +67,7 @@ function makeContourAttr(axLetter) {
highlightcolor: {
valType: 'color',
role: 'style',
dflt: '#000'
dflt: Color.defaultLine,
},
highlightwidth: {
valType: 'number',
Expand Down
Binary file modified test/image/baselines/gl3d_contour-lines.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.