Skip to content

Add new formatting options by replacing d3.format method with more recent d3-format module #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 17, 2021
Merged

Add new formatting options by replacing d3.format method with more recent d3-format module #5125

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5092c19
apply latest d3 number format instead of d3 v3 format
archmoj Jun 26, 2021
cd0d392
update baselines
archmoj Jun 26, 2021
c7ecdc7
reflect schema changes
archmoj Jul 7, 2021
320b270
draft log for PR 5615
archmoj Jul 7, 2021
3ea8d90
refactor adjustFormat
archmoj Jul 12, 2021
a5fd000
refactor number format functions
archmoj Jul 12, 2021
6b93e61
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 12, 2021
25a30a8
catch and handle bad d3 number format instead of throwing error
archmoj Jul 12, 2021
05b221c
point to d3-format v1.4.5 options not higher
archmoj Jul 12, 2021
a5a94cd
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 12, 2021
e88a134
link d3 v3 without d3.format
archmoj Jul 12, 2021
d5d282d
edit draft log
archmoj Jul 12, 2021
68fe2b7
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 12, 2021
17e73b6
cast to string in the case of bad format
archmoj Jul 12, 2021
785f128
add jasmine tests
archmoj Jul 12, 2021
dc0d9cb
removed d3.time now switch to use d3-time
archmoj Jul 13, 2021
a425925
correct comment
archmoj Jul 13, 2021
11a75d9
centralized fn Lib.beginCap to work with new d3 methods
archmoj Jul 13, 2021
dc94854
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 13, 2021
bdb69fc
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 14, 2021
693ebd7
Update src/lib/index.js
archmoj Jul 17, 2021
1efc41e
use titleCase function
archmoj Jul 17, 2021
878034b
warn once encountered a bad format
archmoj Jul 17, 2021
80d37d2
Merge remote-tracking branch 'origin/master' into new-d3-number-format
archmoj Jul 17, 2021
518029a
update baseline using Raleway font instead of Dosis
archmoj Jul 17, 2021
32898a1
bump plotly/d3 to v3.8.0
archmoj Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/master' into new-d3-number-format
  • Loading branch information
@archmoj
archmoj committed Jul 12, 2021
commit 68fe2b7dff04b526c595c97cdf7cee04d353b253

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.