Skip to content

Add half-year directive (%h) for formatting dates and improve descriptions to include extra date formatting options #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 7 commits into from
Jun 24, 2021
Merged

Add half-year directive (%h) for formatting dates and improve descriptions to include extra date formatting options #5762

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e2508bc
add half-year format directive
archmoj Jun 23, 2021
efcbfaa
refactor - centralize axis format descriptions
archmoj Jun 24, 2021
defaf8e
add half-year directive to descriptions
archmoj Jun 24, 2021
98a90ce
mention extra date formatting options in (x|y)hoverformat too
archmoj Jun 24, 2021
73676ca
add dots after links to end the sentences
archmoj Jun 24, 2021
4caa5d8
maintain string type
archmoj Jun 24, 2021
7808217
rename file to axis_format_attributes
archmoj Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
maintain string type
  • Loading branch information
@archmoj
archmoj committed Jun 24, 2021
commit 4caa5d8a95254ee3ef5329c1e0b551246e0c4474
8 changes: 4 additions & 4 deletions src/lib/dates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,10 @@ exports.cleanDate = function(v, dflt, calendar) {
var fracMatch = /%\d?f/g;
var halfYearMatch = /%h/g;
var quarterToHalfYear = {
'1': 1,
'2': 1,
'3': 2,
'4': 2,
'1': '1',
'2': '1',
'3': '2',
'4': '2',
};
function modDateFormat(fmt, x, formatter, calendar) {
fmt = fmt.replace(fracMatch, function(match) {
Expand Down