Skip to content

Sort plot-schema and add test to track plot-schema changes #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 7, 2021
Merged

Sort plot-schema and add test to track plot-schema changes #5776

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
df2670d
move make_schema from tasks/util to tasks
archmoj Jun 26, 2021
677e7ec
create make-schema script
archmoj Jun 26, 2021
94a83dc
do not compress build/plotly.js
archmoj Jun 26, 2021
76588ae
use make-schema for writing to build as well as dist
archmoj Jun 27, 2021
09dfb34
rename make-schema script to schema
archmoj Jun 28, 2021
818a25b
sort plot schema object before writting to file
archmoj Jun 28, 2021
45f6774
commit schema file as a baseline in test folder & compate with auto-g…
archmoj Jun 28, 2021
4b238c4
add a note on how to pass plot-schema diff test
archmoj Jun 28, 2021
0b3ae0d
move schema diff test to publish-dist container for early failure
archmoj Jun 28, 2021
74cbded
Merge remote-tracking branch 'origin/master' into plot-schema-script
archmoj Jun 29, 2021
a451667
Update tasks/util/sort_object.js
archmoj Jun 30, 2021
aea3022
sort arrays of objects in schema
archmoj Jun 30, 2021
98344b6
improve handling dist argument to work with node in addition to npm
archmoj Jun 30, 2021
6168306
remove alternative to test dashboard
archmoj Jun 30, 2021
ef99353
update CONTRIBUTING in regards with schema script
archmoj Jun 30, 2021
916f1f9
Merge remote-tracking branch 'origin/master' into plot-schema-script
archmoj Jul 7, 2021
fcd799e
draft log for pull 5776
archmoj Jul 7, 2021
b29defe
Update CONTRIBUTING.md
archmoj Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve handling dist argument to work with node in addition to npm
  • Loading branch information
@archmoj
archmoj committed Jun 30, 2021
commit 98344b63b10c3ecc439fcd58d14f9041eccf965f
2 changes: 1 addition & 1 deletion tasks/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function makeSchema(plotlyPath, schemaPath) {
}
}

var isDist = process.argv[2] === 'dist';
var isDist = process.argv.indexOf('dist') !== -1;

var pathToSchema = isDist ?
constants.pathToSchemaDist :
Expand Down