Skip to content

Fix period positioned hover to work in different time zones as well as on grouped bars #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 14 commits into from
Jul 29, 2021
Merged

Fix period positioned hover to work in different time zones as well as on grouped bars #5864

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
01b4836
clear special handling for bars and scatter
archmoj Jul 28, 2021
585ddbd
new fix to work in different time zones
archmoj Jul 28, 2021
528801a
adjust test
archmoj Jul 28, 2021
b400917
run hover label tests in different time zones
archmoj Jul 28, 2021
138707c
log for PR 5864
archmoj Jul 28, 2021
21fa988
do not redefine minPos and maxPos functions for bars with period
archmoj Jul 29, 2021
3bdbedb
declare and reuse a variable for isClosest or period in bar hover
archmoj Jul 29, 2021
3ba7ec7
fixing hover for period group bars issue 5841
archmoj Jul 29, 2021
3e52b94
look into cd0 for the case of box and violin
archmoj Jul 29, 2021
bfed46b
more strict tests to lock issue 5841
archmoj Jul 29, 2021
2c07925
update PR log
archmoj Jul 29, 2021
1b7fba1
bring parts of the previous logic - use (x|y)End instead of pEnd etc.
archmoj Jul 29, 2021
4d2961d
handle undefined start and end periods
archmoj Jul 29, 2021
1890e77
simplification for bar
archmoj Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle undefined start and end periods
  • Loading branch information
@archmoj
archmoj committed Jul 29, 2021
commit 4d2961d5cc676ecb1628f5146659220517a2191e
6 changes: 6 additions & 0 deletions src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2000,9 +2000,15 @@ function getCoord(axLetter, winningPoint, fullLayout) {
var periodalignment = winningPoint.trace[axLetter + 'periodalignment'];
if(periodalignment) {
var d = winningPoint.cd[winningPoint.index];

var start = d[axLetter + 'Start'];
if(start === undefined) start = d[axLetter];

var end = d[axLetter + 'End'];
if(end === undefined) end = d[axLetter];

var diff = end - start;

if(periodalignment === 'end') {
val += diff;
} else if(periodalignment === 'middle') {
Expand Down