Skip to content

Use hoverlabel.font for group titles in unified hover modes #5895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 25, 2021
Merged

Use hoverlabel.font for group titles in unified hover modes #5895

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
868a41c
refactor keys in unified hover legend mock
archmoj Aug 17, 2021
9759b9f
use 1.1 X hoverlable.font instead of legendgrouptitle.font in unified…
archmoj Aug 17, 2021
259c38d
use 1.2 X hoverlable.font for title in unified hover
archmoj Aug 17, 2021
2fe0490
draft log for PR 5895
archmoj Aug 17, 2021
870b2e6
use hoverlabel font for main and group titles
archmoj Aug 24, 2021
d95d1f1
move assert function inside the test
archmoj Aug 25, 2021
111c3ee
add jasmine test
archmoj Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add jasmine test
  • Loading branch information
@archmoj
archmoj committed Aug 25, 2021
commit 111c3ee62d706c92d240320636d272e24baffaf9
34 changes: 34 additions & 0 deletions test/jasmine/tests/hover_label_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ var assertElemRightTo = customAssertions.assertElemRightTo;
var assertElemTopsAligned = customAssertions.assertElemTopsAligned;
var assertElemInside = customAssertions.assertElemInside;

var groupTitlesMock = require('@mocks/legendgroup-titles');

function touch(path, options) {
var len = path.length;
Lib.clearThrottle();
Expand Down Expand Up @@ -6078,6 +6080,38 @@ describe('hovermode: (x|y)unified', function() {
.then(done, done.fail);
});

it('should use hoverlabel.font for group titles as well as traces', function(done) {
function assertFont(fontFamily, fontSize, fontColor) {
var hover = getHoverLabel();
var traces = hover.selectAll('g.traces');

traces.each(function() {
var e = d3Select(this);
var text = e.select('text.legendtext');
var node = text.node();

var textStyle = window.getComputedStyle(node);
expect(textStyle.fontFamily.split(',')[0]).toBe(fontFamily, 'wrong font family');
expect(textStyle.fontSize).toBe(fontSize, 'wrong font size');
expect(textStyle.fill).toBe(fontColor, 'wrong font color');
});
}

var mockCopy = Lib.extendDeep({}, groupTitlesMock);

mockCopy.layout.hoverlabel = {
font: {size: 20, family: 'Mono', color: 'rgb(255, 127, 0)'}
};

Plotly.newPlot(gd, mockCopy)
.then(function(gd) {
_hover(gd, { xval: 0});

assertFont('Mono', '20px', 'rgb(255, 127, 0)');
})
.then(done, done.fail);
});

it('should work with hovertemplate', function(done) {
var mockCopy = Lib.extendDeep({}, mock);
mockCopy.data[0].hovertemplate = 'hovertemplate: %{y:0.2f}';
Expand Down