Skip to content

Miscellaneous mapbox tweaks #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 16 commits into from
Jun 23, 2016
Merged

Miscellaneous mapbox tweaks #681

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9c72548
make scattermapbox defaults compatible with lineDefaults again
etpinard Jun 22, 2016
4a8563b
add webgl-support check in mapbox test suites
etpinard Jun 22, 2016
32973fc
add layer type 'circle' :
etpinard Jun 22, 2016
17f3378
add special case to needsNewSource logic
etpinard Jun 22, 2016
053058a
lint long line
etpinard Jun 22, 2016
c1cd50c
make sure the bearing and pitch are updated on map move
etpinard Jun 22, 2016
a899283
fix path the image diff (fixes npm run start-image_viewer)
etpinard Jun 22, 2016
34d5275
rm textfont.family settting (for now),
etpinard Jun 22, 2016
cf27e55
factor out convert text opts logic into file of its own
etpinard Jun 22, 2016
1620e61
make 'color' a shared attribute among layers at all types
etpinard Jun 22, 2016
51fa1ea
add 'symbol' layer type
etpinard Jun 22, 2016
60e4285
pass layer 'color' to mapbox layer paint
etpinard Jun 22, 2016
0d082e4
make 'circle' the default layer type
etpinard Jun 22, 2016
0fdf70c
make 'marker' the default layer symbol icon
etpinard Jun 22, 2016
cb854fe
fixup symbo.iconsize description
etpinard Jun 23, 2016
752c419
make layer type change go through a source refresh,
etpinard Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make scattermapbox defaults compatible with lineDefaults again
  • Loading branch information
@etpinard
etpinard committed Jun 22, 2016
commit 9c7254887954c77c8010d4896babd57fd9d703d2
2 changes: 1 addition & 1 deletion src/traces/scattermapbox/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
coerce('mode');

if(subTypes.hasLines(traceOut)) {
handleLineDefaults(traceIn, traceOut, defaultColor, coerce);
handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce);
coerce('connectgaps');
}

Expand Down