Skip to content

Scale gl3d error bars #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2015
Merged

Scale gl3d error bars #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
911796c
lint: gl-vis --> plotly.js
etpinard Dec 3, 2015
d074741
fix gl3d errorbar convert step:
etpinard Dec 3, 2015
dca44b9
update error bar width rescaling to match 2d
etpinard Dec 3, 2015
972461f
add two image tests
etpinard Dec 3, 2015
cda8431
improve 3d test image cases
etpinard Dec 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add two image tests
  • Loading branch information
@etpinard
etpinard committed Dec 3, 2015
commit 972461f00bcc338db65faa32f25d7fe2e012c02b
Binary file added test/image/baselines/gl3d_errorbars_zx.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added test/image/baselines/gl3d_errorbars_zy.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
65 changes: 65 additions & 0 deletions test/image/mocks/gl3d_errorbars_zx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"data": [
{
"type": "scatter3d",
"mode": "markers",
"x": [
1,
2,
3
],
"y": [
1,
2,
3
],
"z": [
2000,
1000,
2000
],
"error_z": {
"array": [
1000,
500,
1000
],
"arrayminus": [
0,
500,
0
],
"color": "green",
"thinkness": 5
Copy link
Collaborator

@alexcjohnson alexcjohnson Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't "think" that's what you meant

Copy link
Contributor Author

@etpinard etpinard Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha good catch. Thanks.

},
"error_x": {
"type": "constant",
"value": 0.1,
"color": "black"
},
"marker": {
"symbol": "square"
},
"uid": "0c6e64"
}
],
"layout": {
"scene": {
"camera": {
"eye": {
"x": 0.2,
"y": 3.5,
"z": 0.4
}
},
"aspectratio": {
"x": 2,
"y": 2,
"z": 1
}
},
"height": 450,
"width": 1000,
"autosize": true
}
}
53 changes: 53 additions & 0 deletions test/image/mocks/gl3d_errorbars_zy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"data": [
{
"type": "scatter3d",
"x": [
1,
2,
3
],
"y": [
1,
2,
3
],
"z": [
200,
100,
200
],
"error_z": {
"type": "percent",
"value": 20,
"color": "red",
"width": 0.5
Copy link
Collaborator

@alexcjohnson alexcjohnson Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sposed to add caps, right? Want to make it bigger so we can see them and verify that they end up looking similar to caps that size on 2D svg error bars?

Copy link
Contributor Author

@etpinard etpinard Dec 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. my mistake

},
"error_y": {
"type": "constant",
"value": 0.25,
"valueminus": 0.1
},
"uid": "a8f51d"
}
],
"layout": {
"scene": {
"camera": {
"eye": {
"x": 3,
"y": 0.2,
"z": 0.2
}
},
"aspectratio": {
"x": 2,
"y": 2,
"z": 1
}
},
"height": 450,
"width": 1000,
"autosize": true
}
}