Skip to content

added the option for multiple binsizes #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2016
Merged

added the option for multiple binsizes #455

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19d398a
added the option for multiple binsize
yankev May 9, 2016
54e91f4
updated plot schema
yankev May 9, 2016
7eca185
backwards compatibility
yankev May 9, 2016
77086f5
fixed the length of the array
yankev May 9, 2016
4bb9482
added test for the binsize array input
yankev May 9, 2016
7815e59
made PR review changes
yankev May 13, 2016
7a8ef34
added newline
yankev May 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
backwards compatibility
  • Loading branch information
@yankev
yankev committed May 9, 2016
commit 7eca18573554113fac1688a8062dbb7ee5a221e4
5 changes: 4 additions & 1 deletion plotly/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2450,9 +2450,12 @@ def create_distplot(hist_data, group_labels,
"""
# TODO: protected until #282
from plotly.graph_objs import graph_objs
FigureFactory._validate_distplot(hist_data, curve_type) #<--- working on this right now
FigureFactory._validate_distplot(hist_data, curve_type)
FigureFactory._validate_equal_length(hist_data, group_labels)

if isinstance(bin_size, float):
bin_size = [bin_size]

hist = _Distplot(
hist_data, group_labels, bin_size,
curve_type, colors, rug_text,
Expand Down