Skip to content

Conversation

@nahanil
Copy link
Contributor

@nahanil nahanil commented Jul 13, 2016

Heya, have hacked this together. Forgive me if I've done it 'the wrong way' but it seems to work. Docs I referenced are at http://download1.parallels.com/Plesk/PP12/12.0/Doc/fr-FR/online/plesk-api-rpc/index.htm?fileName=33929.htm

Pass it one of ['name', 'owner-id', 'owner-login', 'guid', 'id']
And optionally either or both of since_date/to_date. You can see what I mean in examples/get_traffic.php

"Dates" are simple strings, YYYY-MM-DD. Not sure if it should accept/return this and/or a DateTime object instead.

Also not sure if the GetTraffic class should override BaseRequest's checkResponse method to check error_code/error_text in the response... Doesn't look like any of the other classes do this.

@nahanil nahanil changed the title Add support for get_traffic Add support for get_traffic/GetTraffic Jul 13, 2016
@pmill pmill merged commit 2d5a8be into pmill:dev Aug 14, 2016
@pmill
Copy link
Owner

pmill commented Aug 14, 2016

Thanks, sorry for the delay, I'll include this in the next tagged release.

@nahanil
Copy link
Contributor Author

nahanil commented Oct 14, 2016

Woohoo! No worries about the delay really. Keep up the good work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants