Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add options validator
  • Loading branch information
pmmmwh committed Mar 2, 2020
commit a0de3b5d68b78b321b54d651d9922e9cced6ea08
2 changes: 2 additions & 0 deletions src/helpers/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
const createRefreshTemplate = require('./createRefreshTemplate');
const injectRefreshEntry = require('./injectRefreshEntry');
const validateOptions = require('./validateOptions');

module.exports = {
createRefreshTemplate,
injectRefreshEntry,
validateOptions,
};
41 changes: 41 additions & 0 deletions src/helpers/validateOptions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/** @type {import('../types').ReactRefreshPluginOptions} */
const defaultOptions = {
disableRefreshCheck: false,
forceEnable: false,
useLegacyWDSSockets: false,
};

/** @type {import('../types').ErrorOverlayOptions} */
const defaultOverlayOptions = {
entry: require.resolve('../runtime/ErrorOverlayEntry'),
overlay: require.resolve('../overlay'),
};

/**
* Validates the options for the plugin.
* @param {import('../types').ReactRefreshPluginOptions} options Non-validated plugin options object.
* @returns {import('../types').ReactRefreshPluginOptions} Validated plugin options.
*/
module.exports = function validateOptions(options) {
const validatedOptions = Object.assign(defaultOptions, options);

if (typeof validatedOptions.overlay !== 'boolean') {
if (typeof validatedOptions.overlay.module !== 'string') {
throw new Error(
`To use the "overlay" option, a string must be provided in the "module" property. Instead, the provided value has type: "${typeof options
.overlay.module}".`
);
}

validatedOptions.overlay = {
entry: options.overlay.entry || defaultOverlayOptions.entry,
module: options.overlay.module,
};
} else {
validatedOptions.overlay =
(typeof validatedOptions.overlay === 'undefined' || validatedOptions.overlay) &&
defaultOverlayOptions;
}

return validatedOptions;
};
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class ReactRefreshPlugin {
* @returns {void}
*/
constructor(options) {
this.options = Object.assign(defaultOptions, options);
this.options = validateOptions(options);
}

/**
Expand Down