Update examples code #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is awesome, I think it will be much easier for newcomers to understand the coordinate system |
Member
|
I didn't read this clearly the first time. The ES6 conversion is even more awesome than the adjusted coordinates. I'm super excited to have this. |
marcofugaro
force-pushed
the
examples-update
branch
from
5e6bc8e to
adbf468
Compare
Closed
marcofugaro
force-pushed
the
examples-update
branch
from
cf03217 to
1e0ac59
Compare
Member
Author
|
@codynova this PR is finally ready for review 🥳 |
Member
|
Amazing work, this is massive 🎺 |
codynova
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adjusting the cylinder orientation to the new one, I discovered that the examples are implemented in the
Z up left-handedcoordinate system.This PR updates the examples to use the OpenGL and WebGL standard coordinate system
Y up right-handed.While at it i decided also to
TrackballControlswithOrbitControls, they make more senseThe visual result should be the same, since only the code changes.