Update type definitions #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State is optional on keyframes when you have a default animation; delay was missing on SpringProps
PrecociouslyDigital
changed the title
Make it so that other props can be added to current primitives, to support prop forwarding. Also automatically support prop forwarding from Keyframes to inbuilt primitives
PrecociouslyDigital
changed the title
Nevermind this doesn't do what I thought it would do
Typescript is both beautiful and terrible at the same time
lasseborly
reviewed
Jul 24, 2018
index.d.ts
Outdated
| type TransitionKeyProps = string | number | ||
| type TransitionItemProps = string | number | object | ||
| type TransitionKeyProps = string | number; | ||
| type TransitionItemProps = string | number | object; |
There was a problem hiding this comment.
Intentionally added lonely semi-colons @PrecociouslyDigital ? 😊
There was a problem hiding this comment.
Oops; My linter is having a fit with the code styles and might have accidentally added them. Personally I think the standard should be semi-colons, but I thought it was better to be consistent
There was a problem hiding this comment.
Yeah I agree @PrecociouslyDigital. Cool!
Make the Omit type (the Pick<> Exclude<> combo) correctly omit the "to" property of springprops
Don't allow `to` on other props objects either
szjemljanoj
pushed a commit
to szjemljanoj/react-spring
that referenced
this pull request
Mar 29, 2019
Update type definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State is optional on keyframes when you have a default animation; delay was missing on SpringProps