Skip to content

Official support for React18 incl StrictMode #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 4, 2022
Merged

Official support for React18 incl StrictMode #1875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
872fa7a
chore: update some deps
joshuaellis Apr 5, 2022
d491a4e
fix: cleanup observers in layout cleanup
joshuaellis Apr 6, 2022
b87e07d
chore: update peerdeps
joshuaellis Apr 6, 2022
9466bc4
chore: add changesets
joshuaellis Apr 6, 2022
5b1e03c
fix: useTransition on initial mount
joshuaellis Apr 14, 2022
9295fd1
chore: bump @types packages and fix TS errors
joshuaellis May 2, 2022
27961f7
fix: generic In and Out are reserved words in ts 4.7
joshuaellis May 2, 2022
b043679
refactor: use better(?) plugin for snapshots
joshuaellis May 4, 2022
b89e74e
fix: docs site
joshuaellis May 4, 2022
932ddfd
Merge branch 'master' into feat/react-18
joshuaellis May 4, 2022
f3f11ba
chore: tidy ups
joshuaellis May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: tidy ups
  • Loading branch information
@joshuaellis
joshuaellis committed May 4, 2022
commit f3f11ba4ffd581712eab108822edb49e9737035a
2 changes: 1 addition & 1 deletion demo/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"compilerOptions": {
"target": "ESNext",
"lib": ["DOM", "DOM.Iterable", "ESNext"],
"types": ["vite/client", "react-dom/next"],
"types": ["vite/client"],
"allowJs": true,
"skipLibCheck": false,
"esModuleInterop": false,
Expand Down
10 changes: 9 additions & 1 deletion packages/core/src/hooks/useTransition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,15 @@ export function useTransition(
usedTransitions.current = transitions
})

// Destroy all transitions on dismount.
useOnce(() => {
/**
* This _should_ only run in `StrictMode` where everything
* is destroyed and remounted, because the enter animation
* was most likely cancelled we run it again on initial mount.
*
* This does nothing when `StrictMode` isn't enabled,
* because usedTransitions on mount is typically null.
*/
each(usedTransitions.current!, t => {
t.ctrl.ref?.add(t.ctrl)
const change = changes.get(t)
Expand All @@ -112,6 +119,7 @@ export function useTransition(
}
})

// Destroy all transitions on dismount.
return () => {
each(usedTransitions.current!, t => {
if (t.expired) {
Expand Down